Page MenuHomePhabricator
Differential D12835

Multi-day non-all-day events should be displayed on middle day day views
ClosedPublic
Actions

Authored by lpriestley on May 14 2015, 2:45 AM.
Tags
None
Referenced Files
F14017514: D12835.diff
Mon, Nov 4, 6:16 PM
F14015643: D12835.diff
Sun, Nov 3, 11:10 PM
F14006891: D12835.id30867.diff
Mon, Oct 28, 8:29 PM
F14005273: D12835.diff
Sun, Oct 27, 10:28 AM
F14003611: D12835.id30869.diff
Sat, Oct 26, 8:21 AM
F13970588: D12835.id30868.diff
Thu, Oct 17, 8:35 AM
F13967822: D12835.id30869.diff
Wed, Oct 16, 4:12 PM
Unknown Object (File)
Sep 23 2024, 6:15 PM
View All Files
Subscribers
epriestley
Korvin

Details

Reviewers
epriestley
Group Reviewers
Blessed Reviewers
Maniphest Tasks
T8192: Multi-day non-all-day events not appearing on middle day day view.
Commits
Restricted Diffusion Commit
rPf233672feb52: Multi-day non-all-day events should be displayed on middle day day views
Summary

Fixes T8192, Multi-day non-all-day events should be displayed on middle day day views

Test Plan

Create non-all-day event May 20 12pm - May23 12pm, open May 21 day view. Event should span the entire day.

Diff Detail

Repository
rP Phabricator
Branch
calendarmultidaynonallday
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 5966
Build 5986: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

lpriestley updated this revision to Diff 30867.May 14 2015, 2:45 AM
lpriestley retitled this revision from to Multi-day non-all-day events should be displayed on middle day day views.
lpriestley updated this object.
lpriestley edited the test plan for this revision. (Show Details)
lpriestley added a reviewer: epriestley.
lpriestley added a task: T8192: Multi-day non-all-day events not appearing on middle day day view..
Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptMay 14 2015, 2:45 AM
Herald added subscribers: epriestley, Korvin. · View Herald Transcript
lpriestley updated this revision to Diff 30868.May 14 2015, 2:45 AM
lpriestley edited edge metadata.

cleaning up debugging code

epriestley accepted this revision.May 14 2015, 2:55 AM
epriestley edited edge metadata.
This revision is now accepted and ready to land.May 14 2015, 2:55 AM
Closed by commit rPf233672feb52: Multi-day non-all-day events should be displayed on middle day day views (authored by lpriestley, committed by lpriestley). · Explain WhyMay 14 2015, 2:57 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
view/
phui/
calendar/
25 lines

Diff 30867

View Options

src/view/phui/calendar/PHUICalendarDayView.php

Loading...
Phabricator · Built by Phacility