Page MenuHomePhabricator

Separate handle "status" and "availability"
ClosedPublic

Authored by epriestley on May 13 2015, 10:57 PM.

Details

Summary

Ref T7707. Handles currently have a "status" field and a "disabled" field.

The "status" field has these possible values: "open", "closed", "1", "2". durp durp durp

Instead, do:

  • status = <open, closed>
  • availability = <full, partial, none, disabled>

I think these make more sense? And are a bit more general? And use the same kind of constants for all values!

Test Plan

Looked at all affected handles in all states (probably).

Diff Detail

Repository
rP Phabricator
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

epriestley retitled this revision from to Separate handle "status" and "availability".
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: btrahan.
epriestley edited edge metadata.
  • Look at more handles in more states.
epriestley added inline comments.May 13 2015, 11:01 PM
src/applications/phid/PhabricatorObjectHandle.php
242–246

I suppose I could keep most of this around if it suits your fancy.

Oh, I guess getTextStatus() actually converts 1 and 2 into away and sporadic so they didn't actually make it to handles.

btrahan accepted this revision.May 14 2015, 5:40 PM
btrahan edited edge metadata.
This revision is now accepted and ready to land.May 14 2015, 5:40 PM
This revision was automatically updated to reflect the committed changes.