Differential D12821

Convert inline profile image transforms to new transformations
ClosedPublic
Actions

Authored by epriestley on May 13 2015, 12:37 AM.

Tags

None

Referenced Files

	Unknown Object (File)
	Thu, Apr 25, 1:18 AM

	Unknown Object (File)
	Sat, Apr 13, 10:02 PM

	Unknown Object (File)
	Sat, Apr 13, 10:02 PM

	Unknown Object (File)
	Sat, Apr 13, 9:57 PM

	Unknown Object (File)
	Sat, Apr 13, 9:31 PM

	Unknown Object (File)
	Tue, Apr 9, 11:19 PM

	Unknown Object (File)
	Tue, Apr 2, 7:34 AM

	Unknown Object (File)
	Fri, Mar 29, 3:58 PM

Subscribers

Details

Reviewers

btrahan
chad

Maniphest Tasks

T7879: Profile pictures should have policy settings forced to public/most-open
T7707: Implement a read-through cache layer
T4406: Allow for 100x100 images in profile and projects

Commits

Restricted Diffusion Commit
rP47b14c9bdecf: Convert inline profile image transforms to new transformations

Summary

Ref T7707. Fixes T7879. Fixes T4406. When creating profile images:

Use the new transforms;
mark them as "profile" images so they're forced to the most-open policies.

Test Plan

Set restrictive default file policies.
Changed profile picture, project pictures, etc. Verified they were visible to logged-out users.
Registered via OAuth.
Updated a Conpherence thread image.
Browsed around looking for profile images, fixed sizing on everything I could find.

Diff Detail

Repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

epriestley updated this revision to Diff 30813.May 13 2015, 12:37 AM

epriestley retitled this revision from to Convert inline profile image transforms to new transformations.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added a reviewer: btrahan.

epriestley added tasks: T4406: Allow for 100x100 images in profile and projects, T7707: Implement a read-through cache layer, T7879: Profile pictures should have policy settings forced to public/most-open.

Herald added a reviewer: chad. · View Herald TranscriptMay 13 2015, 12:37 AM

Herald added a subscriber: epriestley. · View Herald Transcript

epriestley mentioned this in T7707: Implement a read-through cache layer.May 13 2015, 1:46 PM

epriestley mentioned this in T4830: Applications with Public permissions requiring users to login.May 13 2015, 3:57 PM

btrahan accepted this revision.May 13 2015, 5:11 PM

btrahan edited edge metadata.

This revision is now accepted and ready to land.May 13 2015, 5:11 PM

Closed by commit rP47b14c9bdecf: Convert inline profile image transforms to new transformations (authored by epriestley, committed by epriestley). · Explain WhyMay 13 2015, 6:40 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

auth/

controller/

PhabricatorAuthRegisterController.php

14 lines

files/

PhabricatorImageTransformer.php

167 lines

controller/

PhabricatorFileComposeController.php

7 lines

PhabricatorFileInfoController.php

6 lines

storage/

PhabricatorFile.php

18 lines

transform/

PhabricatorFileImageTransform.php

6 lines

PhabricatorFileThumbnailTransform.php

10 lines

PhabricatorFileTransform.php

12 lines

people/

controller/

PhabricatorPeopleProfilePictureController.php

9 lines

project/

controller/

PhabricatorProjectEditPictureController.php

9 lines

webroot/

rsrc/

css/

phui/

phui-header-view.css

1 line

phui-timeline-view.css

1 line

Diff 30837

src/applications/auth/controller/PhabricatorAuthRegisterController.php

Loading...

src/applications/files/PhabricatorImageTransformer.php

Loading...

src/applications/files/controller/PhabricatorFileComposeController.php

Loading...

src/applications/files/controller/PhabricatorFileInfoController.php

Loading...

src/applications/files/storage/PhabricatorFile.php

Loading...

src/applications/files/transform/PhabricatorFileImageTransform.php

Loading...

src/applications/files/transform/PhabricatorFileThumbnailTransform.php

Loading...

src/applications/files/transform/PhabricatorFileTransform.php

Loading...

src/applications/people/controller/PhabricatorPeopleProfilePictureController.php

Loading...

src/applications/project/controller/PhabricatorProjectEditPictureController.php

Loading...

webroot/rsrc/css/phui/phui-header-view.css

Loading...

webroot/rsrc/css/phui/phui-timeline-view.css

Loading...