Differential D12817

Quicksand - add phame live URLs to quicksand blacklist
ClosedPublic
Actions

Authored by btrahan on May 12 2015, 8:37 PM.

Details

Reviewers

epriestley

Maniphest Tasks

T8160: Phame blogs don't work with Quicksand

Commits

Restricted Diffusion Commit
rP7bfbc46a635c: Quicksand - add phame live URLs to quicksand blacklist

Summary

Fixes T8160. AFAIK this is the only route pattern that needs blacklisting. Double checked that the resource controller is good to go; it is because its a celerity resource controller descendant and returns data differently than normal controllers

Test Plan

Clicked "view live" on a block. Read a few posts. Clicked into a post and read it. Clicked an image and it linked to the image.

Diff Detail

Repository

rP Phabricator

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

btrahan updated this revision to Diff 30800.May 12 2015, 8:37 PM

btrahan added a task: T8160: Phame blogs don't work with Quicksand.

btrahan retitled this revision from to Quicksand - add phame live URLs to quicksand blacklist.

btrahan updated this object.

btrahan edited the test plan for this revision. (Show Details)

btrahan added a reviewer: epriestley.

Herald added subscribers: epriestley, Korvin. · View Herald TranscriptMay 12 2015, 8:38 PM

epriestley accepted this revision.May 12 2015, 9:30 PM

epriestley edited edge metadata.

This revision is now accepted and ready to land.May 12 2015, 9:30 PM

Closed by commit rP7bfbc46a635c: Quicksand - add phame live URLs to quicksand blacklist (authored by btrahan, committed by btrahan). · Explain WhyMay 12 2015, 9:44 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

phame/

application/

PhabricatorPhameApplication.php

6 lines

Diff 30807

View Options

src/applications/phame/application/PhabricatorPhameApplication.php

Quicksand - add phame live URLs to quicksand blacklistClosedPublicActions