Page MenuHomePhabricator
Differential D12814

Convert "preview" image transforms to new pathway
ClosedPublic
Actions

Authored by epriestley on May 12 2015, 7:29 PM.
Tags
None
Referenced Files
F14441334: D12814.diff
Thu, Dec 26, 6:43 AM
Unknown Object (File)
Tue, Dec 17, 6:33 AM
Unknown Object (File)
Fri, Dec 6, 8:12 AM
Unknown Object (File)
Nov 25 2024, 9:47 PM
Unknown Object (File)
Nov 5 2024, 12:22 AM
Unknown Object (File)
Oct 31 2024, 11:43 PM
Unknown Object (File)
Oct 23 2024, 11:53 PM
Unknown Object (File)
Oct 18 2024, 8:17 PM
View All Files
Subscribers
epriestley

Details

Reviewers
btrahan
Maniphest Tasks
T7707: Implement a read-through cache layer
Commits
Restricted Diffusion Commit
rP75f621123301: Convert "preview" image transforms to new pathway
Summary

Ref T7707. Move the 220px (file uploads) and 100px (Pholio thumbgrid) previews over to the new stuff.

Test Plan

Uploaded a bunch of images to remarkup and Pholio; they generated reasonable results in the web UI.

Diff Detail

Repository
rP Phabricator
Branch
fxform8
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 5925
Build 5945: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

epriestley updated this revision to Diff 30793.May 12 2015, 7:29 PM
epriestley retitled this revision from to Convert "preview" image transforms to new pathway.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: btrahan.
epriestley added a task: T7707: Implement a read-through cache layer.
Herald added a subscriber: epriestley. · View Herald TranscriptMay 12 2015, 7:29 PM
btrahan accepted this revision.May 12 2015, 7:38 PM
btrahan edited edge metadata.
This revision is now accepted and ready to land.May 12 2015, 7:38 PM
Closed by commit rP75f621123301: Convert "preview" image transforms to new pathway (authored by epriestley, committed by epriestley). · Explain WhyMay 13 2015, 6:40 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
resources/
celerity/
4 lines
src/
applications/
files/
70 lines
controller/
14 lines
markup/
16 lines
storage/
8 lines
transform/
10 lines
71 lines
14 lines
pholio/
view/
36 lines
webroot/
rsrc/
image/
icon/
fatcow/
thumbnails/

Diff 30793

View Options

resources/celerity/map.php

Loading...
View Options

src/applications/files/PhabricatorImageTransformer.php

Loading...
View Options

src/applications/files/controller/PhabricatorFileTransformController.php

Loading...
View Options

src/applications/files/markup/PhabricatorEmbedFileRemarkupRule.php

Loading...
View Options

src/applications/files/storage/PhabricatorFile.php

Loading...
View Options

src/applications/files/transform/PhabricatorFileImageTransform.php

Loading...
View Options

src/applications/files/transform/PhabricatorFileThumbnailTransform.php

Loading...
View Options

src/applications/files/transform/PhabricatorFileTransform.php

Loading...
View Options

src/applications/pholio/view/PholioMockThumbGridView.php

Loading...
View Options

webroot/rsrc/image/icon/fatcow/thumbnails/default.p100.png

Loading...
View Options

webroot/rsrc/image/icon/fatcow/thumbnails/image.p100.png

Loading...
View Options

webroot/rsrc/image/icon/fatcow/thumbnails/pdf.p100.png

Loading...
View Options

webroot/rsrc/image/icon/fatcow/thumbnails/zip.p100.png

Loading...
Phabricator · Built by Phacility