Page MenuHomePhabricator
Differential D12814

Convert "preview" image transforms to new pathway
ClosedPublic
Actions

Authored by epriestley on May 12 2015, 7:29 PM.
Tags
None
Referenced Files
F15497435: D12814.diff
Sun, Apr 13, 10:29 AM
F15412788: D12814.id30834.diff
Wed, Mar 19, 2:56 PM
F15395907: D12814.id30793.diff
Sun, Mar 16, 10:40 AM
F15395388: D12814.diff
Sun, Mar 16, 6:34 AM
F15383691: D12814.id30793.diff
Mar 14 2025, 5:35 PM
F15338228: D12814.diff
Mar 9 2025, 9:59 AM
F15302926: D12814.id30834.diff
Mar 5 2025, 11:58 PM
Unknown Object (File)
Feb 8 2025, 4:30 AM
View All Files
Subscribers
epriestley

Details

Reviewers
btrahan
Maniphest Tasks
T7707: Implement a read-through cache layer
Commits
Restricted Diffusion Commit
rP75f621123301: Convert "preview" image transforms to new pathway
Summary

Ref T7707. Move the 220px (file uploads) and 100px (Pholio thumbgrid) previews over to the new stuff.

Test Plan

Uploaded a bunch of images to remarkup and Pholio; they generated reasonable results in the web UI.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley updated this revision to Diff 30793.May 12 2015, 7:29 PM
epriestley retitled this revision from to Convert "preview" image transforms to new pathway.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: btrahan.
epriestley added a task: T7707: Implement a read-through cache layer.
Herald added a subscriber: epriestley. · View Herald TranscriptMay 12 2015, 7:29 PM
btrahan accepted this revision.May 12 2015, 7:38 PM
btrahan edited edge metadata.
This revision is now accepted and ready to land.May 12 2015, 7:38 PM
Closed by commit rP75f621123301: Convert "preview" image transforms to new pathway (authored by epriestley, committed by epriestley). · Explain WhyMay 13 2015, 6:40 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 30834

View Options

src/applications/files/PhabricatorImageTransformer.php

Loading...
View Options

src/applications/files/controller/PhabricatorFileTransformController.php

Loading...
View Options

src/applications/files/markup/PhabricatorEmbedFileRemarkupRule.php

Loading...
View Options

src/applications/files/storage/PhabricatorFile.php

Loading...
View Options

src/applications/files/transform/PhabricatorFileImageTransform.php

Loading...
View Options

src/applications/files/transform/PhabricatorFileThumbnailTransform.php

Loading...
View Options

src/applications/files/transform/PhabricatorFileTransform.php

Loading...
View Options

src/applications/pholio/view/PholioMockThumbGridView.php

Loading...
View Options

webroot/rsrc/image/icon/fatcow/thumbnails/default.p100.png

Loading...
View Options

webroot/rsrc/image/icon/fatcow/thumbnails/image.p100.png

Loading...
View Options

webroot/rsrc/image/icon/fatcow/thumbnails/pdf.p100.png

Loading...
View Options

webroot/rsrc/image/icon/fatcow/thumbnails/zip.p100.png

Loading...
Phabricator · Built by Phacility