Page MenuHomePhabricator
Differential D12800

First pass at Month View
ClosedPublic
Actions

Authored by lpriestley on May 12 2015, 12:31 AM.
Tags
None
Referenced Files
F14311376: D12800.diff
Wed, Dec 18, 2:23 AM
Unknown Object (File)
Sun, Dec 15, 2:59 PM
Unknown Object (File)
Sun, Dec 15, 7:35 AM
Unknown Object (File)
Thu, Dec 12, 5:38 AM
Unknown Object (File)
Mon, Dec 9, 6:00 PM
Unknown Object (File)
Mon, Dec 9, 4:35 AM
Unknown Object (File)
Sun, Dec 8, 3:30 PM
Unknown Object (File)
Sun, Dec 8, 10:25 AM
View All Files
Subscribers
epriestley
Korvin

Details

Reviewers
epriestley
chad
Group Reviewers
Blessed Reviewers
Maniphest Tasks
T4392: Implement "Month" calendar mock
Commits
Restricted Diffusion Commit
rPc4dfc097c8c9: First pass at Month View
Summary

Ref T4392, First pass at Month View

Test Plan

Open month view, month view days should correctly grow with number of events, day numbers should now live at the bottom of day cells, day numbers should be links to day views of those days.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

lpriestley updated this revision to Diff 30765.May 12 2015, 12:31 AM
lpriestley retitled this revision from to First pass at Month View.
lpriestley updated this object.
lpriestley edited the test plan for this revision. (Show Details)
lpriestley added a reviewer: epriestley.
lpriestley added a task: T4392: Implement "Month" calendar mock.
Herald added reviewers: chad, Blessed Reviewers. · View Herald TranscriptMay 12 2015, 12:31 AM
Herald added subscribers: epriestley, Korvin. · View Herald Transcript
lpriestley updated this revision to Diff 30766.May 12 2015, 12:32 AM
lpriestley edited edge metadata.

Celerity meatball

epriestley accepted this revision.May 12 2015, 12:37 AM
epriestley edited edge metadata.
epriestley added inline comments.
src/applications/calendar/query/PhabricatorCalendarEventSearchEngine.php
476–485

Maybe give these methods more consistent names ("...View" vs "...Query")?

src/view/phui/calendar/PHUICalendarListView.php
7–16

Unused?

18–20

Also unused?

91–105

Unused?

src/view/phui/calendar/PHUICalendarMonthView.php
82–83

Maybe deduplicate by defining a variable? This "empty day" structure is specified twice.

webroot/rsrc/css/phui/calendar/phui-calendar-month.css
24–27

Delete?

28–31

Now unused?

64–67

Probably unused?

69–94

You might be able to simplify this a bit by using a consistent padding across both all-day and not-all-day events, instead of mixing padding and margins. Not sure if that would actually work.

This revision is now accepted and ready to land.May 12 2015, 12:37 AM
lpriestley updated this revision to Diff 30767.May 12 2015, 12:43 AM
lpriestley edited edge metadata.
  • wip
lpriestley updated this revision to Diff 30768.May 12 2015, 12:49 AM

Decouple diffs

Closed by commit rPc4dfc097c8c9: First pass at Month View (authored by lpriestley, committed by lpriestley). · Explain WhyMay 12 2015, 1:15 AM
This revision was automatically updated to reflect the committed changes.
lpriestley marked 9 inline comments as done.

Revision Contents
Changeset List

PathSize
resources/
celerity/
4 lines
src/
applications/
calendar/
query/
39 lines
view/
phui/
calendar/
38 lines
100 lines
webroot/
rsrc/
css/
phui/
calendar/
69 lines

Diff 30772

View Options

resources/celerity/map.php

Loading...
View Options

src/applications/calendar/query/PhabricatorCalendarEventSearchEngine.php

Loading...
View Options

src/view/phui/calendar/PHUICalendarListView.php

Loading...
View Options

src/view/phui/calendar/PHUICalendarMonthView.php

Loading...
View Options

webroot/rsrc/css/phui/calendar/phui-calendar-month.css

Loading...
Phabricator · Built by Phacility