Page MenuHomePhabricator

First pass at Month View
ClosedPublic

Authored by lpriestley on May 12 2015, 12:31 AM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Mar 23, 12:46 PM
Unknown Object (File)
Sat, Mar 16, 6:23 PM
Unknown Object (File)
Sat, Mar 16, 6:23 PM
Unknown Object (File)
Sat, Mar 16, 6:15 PM
Unknown Object (File)
Sat, Mar 16, 5:13 PM
Unknown Object (File)
Sat, Mar 16, 4:52 PM
Unknown Object (File)
Sat, Mar 16, 3:56 PM
Unknown Object (File)
Sat, Mar 9, 8:12 PM
Subscribers

Details

Reviewers
epriestley
chad
Group Reviewers
Blessed Reviewers
Maniphest Tasks
T4392: Implement "Month" calendar mock
Commits
Restricted Diffusion Commit
rPc4dfc097c8c9: First pass at Month View
Summary

Ref T4392, First pass at Month View

Test Plan

Open month view, month view days should correctly grow with number of events, day numbers should now live at the bottom of day cells, day numbers should be links to day views of those days.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

lpriestley retitled this revision from to First pass at Month View.
lpriestley updated this object.
lpriestley edited the test plan for this revision. (Show Details)
lpriestley added a reviewer: epriestley.
lpriestley edited edge metadata.

Celerity meatball

epriestley edited edge metadata.
epriestley added inline comments.
src/applications/calendar/query/PhabricatorCalendarEventSearchEngine.php
476–485

Maybe give these methods more consistent names ("...View" vs "...Query")?

src/view/phui/calendar/PHUICalendarListView.php
7–16

Unused?

18–20

Also unused?

91–105

Unused?

src/view/phui/calendar/PHUICalendarMonthView.php
82–83

Maybe deduplicate by defining a variable? This "empty day" structure is specified twice.

webroot/rsrc/css/phui/calendar/phui-calendar-month.css
24–27

Delete?

28–31

Now unused?

64–67

Probably unused?

69–94

You might be able to simplify this a bit by using a consistent padding across both all-day and not-all-day events, instead of mixing padding and margins. Not sure if that would actually work.

This revision is now accepted and ready to land.May 12 2015, 12:37 AM
This revision was automatically updated to reflect the committed changes.
lpriestley marked 9 inline comments as done.