Ref T4392, First pass at Month View
Details
Details
- Reviewers
epriestley chad - Group Reviewers
Blessed Reviewers - Maniphest Tasks
- T4392: Implement "Month" calendar mock
- Commits
- Restricted Diffusion Commit
rPc4dfc097c8c9: First pass at Month View
Open month view, month view days should correctly grow with number of events, day numbers should now live at the bottom of day cells, day numbers should be links to day views of those days.
Diff Detail
Diff Detail
- Repository
- rP Phabricator
- Branch
- calendarmonthviewstyle
- Lint
Lint Passed - Unit
Tests Passed - Build Status
Buildable 5903 Build 5923: [Placeholder Plan] Wait for 30 Seconds
Event Timeline
| src/applications/calendar/query/PhabricatorCalendarEventSearchEngine.php | ||
|---|---|---|
| 476–485 | Maybe give these methods more consistent names ("...View" vs "...Query")? | |
| src/view/phui/calendar/PHUICalendarListView.php | ||
| 7–16 | Unused? | |
| 18–20 | Also unused? | |
| 94–108 | Unused? | |
| src/view/phui/calendar/PHUICalendarMonthView.php | ||
| 77–81 | Maybe deduplicate by defining a variable? This "empty day" structure is specified twice. | |
| webroot/rsrc/css/phui/calendar/phui-calendar-month.css | ||
| 33–38 | Delete? | |
| 40–42 | Now unused? | |
| 75–78 | Probably unused? | |
| 80–105 | You might be able to simplify this a bit by using a consistent padding across both all-day and not-all-day events, instead of mixing padding and margins. Not sure if that would actually work. | |