Differential D12799

Cleaning up day view clusters for events shorter than about 30 minutes
ClosedPublic
Actions

Authored by lpriestley on May 12 2015, 12:27 AM.

Details

Reviewers

epriestley

Group Reviewers

Blessed Reviewers

Commits

Restricted Diffusion Commit
rPb53ecd0d423f: Cleaning up day view clusters for events shorter than about 30 minutes

Summary

Cleaning up day view clusters for events shorter than about 30 minutes

Test Plan

Create two event within 30 minutes, 1 minute long, each. Day view should properly cluster the events.

Diff Detail

Repository

rP Phabricator

Branch

calendarshorteventclusters

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 5901
Build 5921: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

lpriestley updated this revision to Diff 30764.May 12 2015, 12:27 AM

lpriestley retitled this revision from to Cleaning up day view clusters for events shorter than about 30 minutes.

lpriestley updated this object.

lpriestley edited the test plan for this revision. (Show Details)

lpriestley added a reviewer: epriestley.

Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptMay 12 2015, 12:27 AM

Herald added subscribers: epriestley, Korvin. · View Herald Transcript

epriestley accepted this revision.May 12 2015, 12:28 AM

epriestley edited edge metadata.

This revision is now accepted and ready to land.May 12 2015, 12:28 AM

Closed by commit rPb53ecd0d423f: Cleaning up day view clusters for events shorter than about 30 minutes (authored by lpriestley, committed by lpriestley). · Explain WhyMay 12 2015, 1:13 AM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

view/

phui/

calendar/

PHUICalendarDayView.php

7 lines

Diff 30764

View Options

src/view/phui/calendar/PHUICalendarDayView.php

Cleaning up day view clusters for events shorter than about 30 minutesClosedPublicActions