Page MenuHomePhabricator

Conpherence + workboards - fix dragging behavior breaking on subsequent page loads
ClosedPublic

Authored by btrahan on May 11 2015, 11:09 PM.
Tags
None
Referenced Files
F14025777: D12798.id30791.diff
Thu, Nov 7, 8:06 PM
F14013581: D12798.id30791.diff
Sat, Nov 2, 7:51 AM
F14005051: D12798.id30791.diff
Sun, Oct 27, 6:36 AM
F13973714: D12798.diff
Fri, Oct 18, 2:12 AM
Unknown Object (File)
Oct 10 2024, 8:30 AM
Unknown Object (File)
Oct 8 2024, 5:22 AM
Unknown Object (File)
Sep 25 2024, 1:04 AM
Unknown Object (File)
Sep 25 2024, 1:02 AM
Subscribers

Details

Summary

Fixes T8155. The former "init_board()" function was aptly named as it needs to be called each time a new board dom piece is downloaded. Ergo, break out a setup() function and call that in the once-only setup place, and use init_board() there as well as when we have a quicksand redraw event with data from the server.

Test Plan

paged about a project and was able to keep dragging and dropping tasks on various loads of the board. verified drops saved correctly from load to load.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

btrahan retitled this revision from to Conpherence + workboards - fix dragging behavior breaking on subsequent page loads.
btrahan updated this object.
btrahan edited the test plan for this revision. (Show Details)
btrahan added a reviewer: epriestley.
epriestley edited edge metadata.
This revision is now accepted and ready to land.May 12 2015, 12:28 AM
This revision was automatically updated to reflect the committed changes.