Page MenuHomePhabricator

Refine durable column class toggling
ClosedPublic

Authored by btrahan on May 11 2015, 8:46 PM.
Tags
None
Referenced Files
Unknown Object (File)
Apr 26 2025, 11:43 PM
Unknown Object (File)
Apr 24 2025, 2:43 AM
Unknown Object (File)
Apr 11 2025, 5:16 PM
Unknown Object (File)
Apr 10 2025, 5:07 PM
Unknown Object (File)
Apr 6 2025, 10:00 AM
Unknown Object (File)
Mar 19 2025, 10:12 AM
Unknown Object (File)
Mar 10 2025, 11:23 AM
Unknown Object (File)
Feb 25 2025, 6:48 PM
Subscribers

Details

Summary

don't bother with margin class if column isn't visible. Ref T8151.

Test Plan

using chrome with trackpad

  • loaded home with toggled off column - noted no margin class erroneously applied
  • toggled column off and on - correct
  • loaded home with toggled on column - correct
  • toggled column off and on - correct

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

btrahan retitled this revision from to Refine durable column class toggling.
btrahan updated this object.
btrahan edited the test plan for this revision. (Show Details)
btrahan added a reviewer: epriestley.
This revision is now accepted and ready to land.May 11 2015, 8:48 PM
This revision was automatically updated to reflect the committed changes.