Page MenuHomePhabricator
Differential D12791

Deprecating BrowseController and getting rid of unneeded calls to `getTerseSummary()` and `getHumanStatus()`
ClosedPublic
Actions

Authored by lpriestley on May 10 2015, 5:48 PM.
Tags
None
Referenced Files
F18749095: D12791.id30748.diff
Sat, Oct 4, 2:22 AM
F18747705: D12791.diff
Fri, Oct 3, 5:19 PM
F18712573: D12791.diff
Mon, Sep 29, 5:27 AM
F18601763: D12791.diff
Sat, Sep 13, 1:26 PM
F18585902: D12791.diff
Thu, Sep 11, 4:48 PM
Unknown Object (File)
May 17 2025, 1:12 PM
Unknown Object (File)
May 17 2025, 10:35 AM
Unknown Object (File)
May 17 2025, 7:50 AM
View All Files
Subscribers
epriestley
Korvin

Details

Reviewers
epriestley
Group Reviewers
Blessed Reviewers
Maniphest Tasks
T8050: Calendar List formatting
Commits
Restricted Diffusion Commit
rP51facbabba91: Deprecating BrowseController and getting rid of unneeded calls to…
Summary

Ref T8050, Deprecating BrowseController and getting rid of unneeded calls to getTerseSummary() and getHumanStatus()

Test Plan

Use calendar, make sure nothing explodes

Diff Detail

Repository
rP Phabricator
Branch
calendardeprecatebrowsecontroller
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 5890
Build 5910: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

lpriestley updated this revision to Diff 30745.May 10 2015, 5:48 PM
lpriestley retitled this revision from to Deprecating BrowseController and getting rid of unneeded calls to `getTerseSummary()` and `getHumanStatus()`.
lpriestley updated this object.
lpriestley edited the test plan for this revision. (Show Details)
lpriestley added a reviewer: epriestley.
lpriestley added a task: T8050: Calendar List formatting.
Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptMay 10 2015, 5:48 PM
Herald added subscribers: epriestley, Korvin. · View Herald Transcript
epriestley accepted this revision.May 10 2015, 5:52 PM
epriestley edited edge metadata.
This revision is now accepted and ready to land.May 10 2015, 5:52 PM
Closed by commit rP51facbabba91: Deprecating BrowseController and getting rid of unneeded calls to… (authored by lpriestley, committed by lpriestley). · Explain WhyMay 10 2015, 6:14 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
applications/
calendar/
controller/
query/
5 lines
storage/
5 lines

Diff 30745

View Options

src/applications/calendar/controller/PhabricatorCalendarBrowseController.php

Loading...
View Options

src/applications/calendar/query/PhabricatorCalendarEventSearchEngine.php

Loading...
View Options

src/applications/calendar/storage/PhabricatorCalendarEvent.php

Loading...
Phabricator · Built by Phacility