Page MenuHomePhabricator
Differential D12784

Fix conduit result tables on mobile views
ClosedPublic
Actions

Authored by epriestley on May 9 2015, 3:53 PM.
Tags
None
Referenced Files
F14836681: D12784.id30731.diff
Fri, Jan 31, 4:02 AM
Unknown Object (File)
Fri, Jan 24, 6:57 PM
Unknown Object (File)
Fri, Jan 24, 4:19 AM
Unknown Object (File)
Fri, Jan 24, 4:19 AM
Unknown Object (File)
Fri, Jan 24, 4:19 AM
Unknown Object (File)
Fri, Jan 24, 4:19 AM
Unknown Object (File)
Mon, Jan 20, 2:37 PM
Unknown Object (File)
Fri, Jan 3, 8:34 PM
View All Files
Subscribers
epriestley

Details

Reviewers
btrahan
chad
Maniphest Tasks
T8139: Human readable results are not shown
Commits
Restricted Diffusion Commit
rP7668d47e6da1: Fix conduit result tables on mobile views
Summary

Fixes T8139. These tables don't setHeaders(), so we don't correctly default columns to be visible on devices.

Test Plan

Conduit results now visible on devices.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley updated this revision to Diff 30731.May 9 2015, 3:53 PM
epriestley retitled this revision from to Fix conduit result tables on mobile views.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added reviewers: btrahan, chad.
epriestley added a task: T8139: Human readable results are not shown.
Herald added a subscriber: epriestley. · View Herald TranscriptMay 9 2015, 3:53 PM
chad accepted this revision.May 9 2015, 4:33 PM
chad edited edge metadata.
This revision is now accepted and ready to land.May 9 2015, 4:33 PM
Closed by commit rP7668d47e6da1: Fix conduit result tables on mobile views (authored by epriestley, committed by epriestley). · Explain WhyMay 9 2015, 5:05 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
view/
control/
5 lines

Diff 30732

View Options

src/view/control/AphrontTableView.php

Loading...
Phabricator · Built by Phacility