Page MenuHomePhabricator
Differential D12774

All day events should disable time editing in edit view
ClosedPublic
Actions

Authored by lpriestley on May 8 2015, 4:23 PM.
Tags
None
Referenced Files
F19137698: D12774.id30704.diff
Wed, Dec 10, 10:45 AM
F18982344: D12774.diff
Nov 17 2025, 6:39 AM
F18868772: D12774.id.diff
Nov 4 2025, 8:25 AM
F18865991: D12774.diff
Nov 3 2025, 2:55 PM
F18804489: D12774.diff
Oct 18 2025, 8:49 AM
F18786622: D12774.id30706.diff
Oct 14 2025, 7:42 PM
F18704637: D12774.id.diff
Sep 28 2025, 8:21 AM
F18696691: D12774.diff
Sep 27 2025, 8:13 AM
View All Files
Subscribers
epriestley
Korvin

Details

Reviewers
epriestley
chad
Group Reviewers
Blessed Reviewers
Maniphest Tasks
T8021: Implement "All Day" events
Commits
Restricted Diffusion Commit
rPd249456a0414: All day events should disable time editing in edit view
Summary

Closes T8021, All day events should disable time editing in edit view

Test Plan

Edit all day event, time text fields should be disabled. Unchecking all-day should show time fields.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

lpriestley updated this revision to Diff 30704.May 8 2015, 4:23 PM
lpriestley retitled this revision from to All day events should disable time editing in edit view.
lpriestley updated this object.
lpriestley edited the test plan for this revision. (Show Details)
lpriestley added a reviewer: epriestley.
lpriestley added a task: T8021: Implement "All Day" events.
Herald added reviewers: chad, Blessed Reviewers. · View Herald TranscriptMay 8 2015, 4:23 PM
Herald added subscribers: epriestley, Korvin. · View Herald Transcript
chad edited edge metadata.May 8 2015, 4:25 PM

itsawesome

epriestley accepted this revision.May 8 2015, 4:44 PM
epriestley edited edge metadata.
This revision is now accepted and ready to land.May 8 2015, 4:44 PM
Closed by commit rPd249456a0414: All day events should disable time editing in edit view (authored by lpriestley, committed by lpriestley). · Explain WhyMay 8 2015, 5:01 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
resources/
celerity/
2 lines
src/
applications/
calendar/
controller/
25 lines
view/
form/
control/
13 lines
10 lines
webroot/
rsrc/
css/
phui/
4 lines
js/
application/
calendar/
16 lines

Diff 30706

View Options

resources/celerity/map.php

Loading...
View Options

src/applications/calendar/controller/PhabricatorCalendarEventEditController.php

Loading...
View Options

src/view/form/control/AphrontFormCheckboxControl.php

Loading...
View Options

src/view/form/control/AphrontFormDateControl.php

Loading...
View Options

webroot/rsrc/css/phui/phui-form-view.css

Loading...
View Options

webroot/rsrc/js/application/calendar/event-all-day.js

Loading...
Phabricator · Built by Phacility