Page MenuHomePhabricator
Differential D12772

Change latest and earliest saved timezones on all day events to php official timezones instead of guessing GMT offsets
ClosedPublic
Actions

Authored by lpriestley on May 8 2015, 2:41 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Dec 21, 2:18 AM
Unknown Object (File)
Fri, Dec 20, 1:17 PM
Unknown Object (File)
Thu, Dec 19, 10:56 AM
Unknown Object (File)
Tue, Dec 17, 7:44 AM
Unknown Object (File)
Sat, Dec 14, 4:49 PM
Unknown Object (File)
Fri, Dec 6, 7:29 AM
Unknown Object (File)
Wed, Nov 27, 1:52 AM
Unknown Object (File)
Sat, Nov 23, 3:03 PM
View All Files
Subscribers
epriestley
Korvin

Details

Reviewers
epriestley
Group Reviewers
Blessed Reviewers
Maniphest Tasks
T8021: Implement "All Day" events
Commits
Restricted Diffusion Commit
rP559ba4e94435: Change latest and earliest saved timezones on all day events to php official…
Summary

Ref T8021, Change latest and earliest saved timezones on all day events to php official timezones instead of guessing GMT offsets

Test Plan

On different versions of php, create and save all day event in various timezones without errors.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

lpriestley updated this revision to Diff 30697.May 8 2015, 2:41 PM
lpriestley retitled this revision from to Change latest and earliest saved timezones on all day events to php official timezones instead of guessing GMT offsets.
lpriestley updated this object.
lpriestley edited the test plan for this revision. (Show Details)
lpriestley added a reviewer: epriestley.
lpriestley added a task: T8021: Implement "All Day" events.
Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptMay 8 2015, 2:41 PM
Herald added subscribers: epriestley, Korvin. · View Herald Transcript
epriestley requested changes to this revision.May 8 2015, 2:55 PM
epriestley edited edge metadata.
epriestley added inline comments.
test.php
1 ↗(On Diff #30697)

oh, remove this file

This revision now requires changes to proceed.May 8 2015, 2:55 PM
lpriestley updated this revision to Diff 30700.May 8 2015, 3:03 PM
lpriestley edited edge metadata.

Removing test file.

epriestley accepted this revision.May 8 2015, 3:06 PM
epriestley edited edge metadata.
This revision is now accepted and ready to land.May 8 2015, 3:06 PM
Closed by commit rP559ba4e94435: Change latest and earliest saved timezones on all day events to php official… (authored by lpriestley, committed by lpriestley). · Explain WhyMay 8 2015, 3:07 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
applications/
calendar/
storage/
8 lines

Diff 30701

View Options

src/applications/calendar/storage/PhabricatorCalendarEvent.php

Loading...
Phabricator · Built by Phacility