Differential D12771

Clear project notifications when viewing workboard or project detail
ClosedPublic
Actions

Authored by epriestley on May 8 2015, 1:51 PM.

Details

Reviewers

btrahan

Maniphest Tasks

T8112: Visiting project pages doesn't clear notifications about them

Commits

Restricted Diffusion Commit
rP7beae445e9ee: Clear project notifications when viewing workboard or project detail

Summary

Fixes T8112.

Test Plan

Sent notifications.
Notied them un-cleared by clicking them (profile or workboard).
Made changes.
Verified profile and workboard both clear them.

Diff Detail

Repository

rP Phabricator

Branch

pnotif

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 5859
Build 5879: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

epriestley updated this revision to Diff 30696.May 8 2015, 1:51 PM

epriestley retitled this revision from to Clear project notifications when viewing workboard or project detail.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added a reviewer: btrahan.

epriestley added a task: T8112: Visiting project pages doesn't clear notifications about them.

Herald added a subscriber: epriestley. · View Herald TranscriptMay 8 2015, 1:51 PM

btrahan accepted this revision.May 8 2015, 5:52 PM

btrahan edited edge metadata.

This revision is now accepted and ready to land.May 8 2015, 5:52 PM

Closed by commit rP7beae445e9ee: Clear project notifications when viewing workboard or project detail (authored by epriestley, committed by epriestley). · Explain WhyMay 8 2015, 7:20 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

project/

controller/

PhabricatorProjectBoardViewController.php

1 line

PhabricatorProjectProfileController.php

1 line

Diff 30696

View Options

src/applications/project/controller/PhabricatorProjectBoardViewController.php