Differential D12758

Conpherence - make sure real time updates still work if you switch threads
ClosedPublic
Actions

Authored by btrahan on May 7 2015, 7:37 PM.

Details

Reviewers

epriestley

Maniphest Tasks

T8118: Non-default chats in the durable column don't update in realtime

Commits

Restricted Diffusion Commit
rP524aee03dca0: Conpherence - make sure real time updates still work if you switch threads

Summary

Fixes T8118. Turns out this also was broken in the main view if e.g. you went to just /conpherence/. The fix is to make sure the threadmanager js class explicitly manages subscriptions as the loaded thread changes.

Test Plan

from /conpherence/ was able to receive messages in real time.
from /conpherence/ changed threads and still received messages in real time
from durable column switched threads and received messages in real time

Diff Detail

Repository

rP Phabricator

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

btrahan updated this revision to Diff 30661.May 7 2015, 7:37 PM

btrahan added a task: T8118: Non-default chats in the durable column don't update in realtime.

btrahan retitled this revision from to Conpherence - make sure real time updates still work if you switch threads.

btrahan updated this object.

btrahan edited the test plan for this revision. (Show Details)

btrahan added a reviewer: epriestley.

Herald added subscribers: epriestley, Korvin. · View Herald TranscriptMay 7 2015, 7:37 PM

btrahan added inline comments.May 7 2015, 7:39 PM

webroot/rsrc/js/application/conpherence/ConpherenceThreadManager.js
285–287	whoops, should be PHID not ID

epriestley accepted this revision.May 7 2015, 7:40 PM

epriestley edited edge metadata.

epriestley added inline comments.

webroot/rsrc/js/application/conpherence/ConpherenceThreadManager.js

282–304

Maybe simpler like this?

var old_subs = client.getSubscriptions();
var new_subs = [];
for (var ii = 0; ii < old_subs.length; ii++) {
  if (old_subs[ii] == this._loadedThreadPHID) {
    new_subs.push(r.threadPHID);
  } else {
    new_subs.push(old_subs[ii]);
  }
}

This revision is now accepted and ready to land.May 7 2015, 7:40 PM