Differential D12747

Fix "reply" to left-side inline appearing on right side
ClosedPublic
Actions

Authored by epriestley on May 7 2015, 12:40 PM.

Details

Reviewers

btrahan

Maniphest Tasks

T8098: Replying to comment on audit will appear in wrong column of diff view

Commits

Restricted Diffusion Commit
rP9d132f177b23: Fix "reply" to left-side inline appearing on right side

Summary

Fixes T8098. This parameter was being misinterpreted over the wire.

Test Plan

Replied to left-side inline, got left-side reply.

Diff Detail

Repository

rP Phabricator

Branch

ireply

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 5822
Build 5842: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

epriestley updated this revision to Diff 30631.May 7 2015, 12:40 PM

epriestley retitled this revision from to Fix "reply" to left-side inline appearing on right side.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added a reviewer: btrahan.

epriestley added a task: T8098: Replying to comment on audit will appear in wrong column of diff view.

Herald added a subscriber: epriestley. · View Herald TranscriptMay 7 2015, 12:40 PM

btrahan accepted this revision.May 7 2015, 5:39 PM

btrahan edited edge metadata.

This revision is now accepted and ready to land.May 7 2015, 5:39 PM

Closed by commit rP9d132f177b23: Fix "reply" to left-side inline appearing on right side (authored by epriestley, committed by epriestley). · Explain WhyMay 7 2015, 6:09 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

resources/

celerity/

map.php

22 lines

webroot/

rsrc/

js/

application/

differential/

DifferentialInlineCommentEditor.js

2 lines

Diff 30631

View Options

resources/celerity/map.php