Page MenuHomePhabricator
Differential D12730

Improve performance of generating synthetic changesets
ClosedPublic
Actions

Authored by epriestley on May 6 2015, 1:02 AM.
Tags
None
Referenced Files
F15463154: D12730.id30614.diff
Apr 1 2025, 8:47 PM
F15451826: D12730.id.diff
Mar 29 2025, 12:01 AM
F15450235: D12730.id30589.diff
Mar 28 2025, 2:40 PM
F15447921: D12730.diff
Mar 28 2025, 2:26 AM
F15427131: D12730.id30614.diff
Mar 23 2025, 1:03 PM
F15407593: D12730.id30589.diff
Mar 18 2025, 6:33 PM
F15381176: D12730.id.diff
Mar 14 2025, 6:18 AM
F15344646: D12730.diff
Mar 10 2025, 6:01 AM
View All Files
Subscribers
epriestley

Details

Reviewers
btrahan
Maniphest Tasks
T7776: Loading delta between two diffs in Differential can result in diffs for large files failing to load
Commits
Restricted Diffusion Commit
rPabe28e628a7c: Improve performance of generating synthetic changesets
Summary

Ref T7776. This could get better, but I think I got most of the big stuff. It's ~4x faster now.

Test Plan

Before:

Screen Shot 2015-05-05 at 6.00.14 PM.png (420×1 px, 98 KB)

After:

Screen Shot 2015-05-05 at 6.00.27 PM.png (665×1 px, 163 KB)

Diff Detail

Repository
rP Phabricator
Branch
syndiff
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 5789
Build 5808: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

epriestley updated this revision to Diff 30589.May 6 2015, 1:02 AM
epriestley retitled this revision from to Improve performance of generating synthetic changesets.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: btrahan.
epriestley added a task: T7776: Loading delta between two diffs in Differential can result in diffs for large files failing to load.
Herald added a subscriber: epriestley. · View Herald TranscriptMay 6 2015, 1:02 AM
epriestley added a comment.May 6 2015, 1:04 AM

Pretty much all of this is just slightly-slow stuff that we do tens of thousands of times more often than we need to on large changes.

btrahan accepted this revision.May 6 2015, 6:10 PM
btrahan edited edge metadata.
This revision is now accepted and ready to land.May 6 2015, 6:10 PM
Closed by commit rPabe28e628a7c: Improve performance of generating synthetic changesets (authored by epriestley, committed by epriestley). · Explain WhyMay 6 2015, 11:43 PM
This revision was automatically updated to reflect the committed changes.
epriestley mentioned this in T7776: Loading delta between two diffs in Differential can result in diffs for large files failing to load.Sep 10 2015, 12:41 AM

Revision Contents
Changeset List

PathSize
src/
applications/
differential/
parser/
26 lines
storage/
31 lines

Diff 30589

View Options

src/applications/differential/parser/DifferentialHunkParser.php

Loading...
View Options

src/applications/differential/storage/DifferentialHunk.php

Loading...
Phabricator · Built by Phacility