Page MenuHomePhabricator

Quicksand - fix toggle behavior to work with quicksand
ClosedPublic

Authored by btrahan on May 4 2015, 9:34 PM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Apr 30, 5:18 PM
Unknown Object (File)
Tue, Apr 30, 5:18 PM
Unknown Object (File)
Tue, Apr 30, 5:18 PM
Unknown Object (File)
Mon, Apr 29, 2:32 PM
Unknown Object (File)
Sun, Apr 28, 7:28 AM
Unknown Object (File)
Thu, Apr 25, 12:53 AM
Unknown Object (File)
Sun, Apr 14, 10:49 PM
Unknown Object (File)
Thu, Apr 11, 8:38 AM
Subscribers

Details

Summary

Fixes T7919. This is a pretty generic toggle behavior. Make it quicksand ready by making it install only once and swallow the regular "click" event so the quicksand "click" event doesn't get funky with it.

Also fixes a bug in Quicksand that I discovered developing / testing this feature. We have to update the internal member variable to be better than 0 similarly to how id works. So do that.

Test Plan

went to phriction, toggled menu open, clicked home, clicked phriction and toggled menu again. Went back in history and noted menu was left to toggle state I previously had it. (currently a feature, not a bug)

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

btrahan retitled this revision from to Quicksand - fix toggle behavior to work with quicksand.
btrahan updated this object.
btrahan edited the test plan for this revision. (Show Details)
btrahan added a reviewer: epriestley.
epriestley edited edge metadata.
This revision is now accepted and ready to land.May 4 2015, 9:36 PM
This revision was automatically updated to reflect the committed changes.