Page MenuHomePhabricator
Differential D12706

Fix a failing XML unit test
ClosedPublic
Actions

Authored by joshuaspence on May 4 2015, 9:30 PM.
Tags
None
Referenced Files
F15574570: D12706.id30514.diff
Tue, May 6, 2:11 AM
F15569224: D12706.diff
Sat, May 3, 6:00 PM
F15562443: D12706.id.diff
Wed, Apr 30, 2:29 AM
F15553526: D12706.id30530.diff
Mon, Apr 28, 2:23 AM
F15553524: D12706.id30514.diff
Mon, Apr 28, 2:23 AM
F15553451: D12706.diff
Mon, Apr 28, 2:08 AM
F15545922: D12706.diff
Sat, Apr 26, 1:26 PM
F15509830: D12706.diff
Wed, Apr 16, 4:23 PM
View All Files
Subscribers
epriestley
Korvin

Details

Reviewers
epriestley
Group Reviewers
Blessed Reviewers
Maniphest Tasks
T7215: ArcanistXMLLinterTestCase test failure
Commits
rARC0a711315f86b: Fix a failing XML unit test
Summary

Ref T7215. This test case is consistently failing locally (with a LIBXML_VERSION of 20902).

Test Plan

arc unit

Diff Detail

Repository
rARC Arcanist
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

joshuaspence updated this revision to Diff 30514.May 4 2015, 9:30 PM
joshuaspence retitled this revision from to Fix a failing XML unit test.
joshuaspence updated this object.
joshuaspence edited the test plan for this revision. (Show Details)
joshuaspence added a reviewer: epriestley.
joshuaspence added a task: T7215: ArcanistXMLLinterTestCase test failure.
Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptMay 4 2015, 9:30 PM
Herald added subscribers: epriestley, Korvin. · View Herald Transcript
epriestley accepted this revision.May 4 2015, 9:31 PM
epriestley edited edge metadata.

Maybe we should just throw this test away given that the result seems version-dependent?

This revision is now accepted and ready to land.May 4 2015, 9:31 PM
joshuaspence added a comment.May 4 2015, 9:32 PM

Yeah maybe. Let me see how many of the tests are failing.

Closed by commit rARC0a711315f86b: Fix a failing XML unit test (authored by joshuaspence, committed by joshuaspence). · Explain WhyMay 5 2015, 8:57 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
lint/
linter/
__tests__/
xml/
2 lines
2 lines
2 lines

Diff 30530

View Options

src/lint/linter/__tests__/xml/attr3.lint-test

Loading...
View Options

src/lint/linter/__tests__/xml/attr4.lint-test

Loading...
View Options

src/lint/linter/__tests__/xml/languages-7.lint-test

Loading...
Phabricator · Built by Phacility