Page MenuHomePhabricator
Differential D12674

Support colloquial time names to dramatically improve usability of time control
ClosedPublic
Actions

Authored by epriestley on May 3 2015, 3:22 PM.
Tags
None
Referenced Files
F13090697: D12674.diff
Thu, Apr 25, 2:31 AM
Unknown Object (File)
Tue, Apr 23, 9:10 AM
Unknown Object (File)
Fri, Apr 19, 8:45 AM
Unknown Object (File)
Fri, Apr 19, 8:45 AM
Unknown Object (File)
Fri, Apr 19, 8:45 AM
Unknown Object (File)
Fri, Apr 19, 8:45 AM
Unknown Object (File)
Fri, Apr 19, 8:38 AM
Unknown Object (File)
Fri, Apr 19, 7:48 AM
View All Files
Subscribers
eadler
epriestley
johnny-bit
Tokens
"Pterodactyl" token, awarded by avivey."Grey Medal" token, awarded by chad.

Details

Reviewers
btrahan
lpriestley
chad
Maniphest Tasks
T8024: Update Calendar event date selection controls
Commits
Restricted Diffusion Commit
rP3ea7359e161d: Support colloquial time names to dramatically improve usability of time control
Summary

Ref T8024. The time control currently does not support colloquial time names frequently used in common parlance. Support these times.

Test Plan

Easily specified many of the most important times in a convenient way.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley updated this revision to Diff 30437.May 3 2015, 3:22 PM
epriestley retitled this revision from to Support colloquial time names to dramatically improve usability of time control.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added reviewers: lpriestley, chad, btrahan.
epriestley added a task: T8024: Update Calendar event date selection controls.
Herald added a subscriber: epriestley. · View Herald TranscriptMay 3 2015, 3:22 PM
epriestley updated this revision to Diff 30438.May 3 2015, 3:24 PM
  • More/better.
chad edited edge metadata.May 3 2015, 3:26 PM

http://en.wikipedia.org/wiki/Elevenses

epriestley updated this revision to Diff 30439.May 3 2015, 3:47 PM
epriestley edited edge metadata.
  • Support monring tea.
chad awarded a token.May 3 2015, 3:49 PM
epriestley added a comment.May 3 2015, 3:49 PM

Other possibilities:

  • "Sunrise"/"Sunset": we need to know the user's latitude, and currently don't prompt for this information.
  • "Top O' The Morning": Not a real time, just a phrase.
lpriestley added inline comments.May 3 2015, 4:08 PM
src/view/form/control/AphrontFormDateControlValue.php
190

How about "lunch"? Not sure about other meals, but lunch seems to be the one most often used and the most standard time.

lpriestley accepted this revision.May 3 2015, 4:08 PM
lpriestley edited edge metadata.
This revision is now accepted and ready to land.May 3 2015, 4:08 PM
eadler added a subscriber: eadler.May 3 2015, 4:19 PM
eadler added inline comments.
src/view/form/control/AphrontFormDateControlValue.php
190

lunch mapping to 12:00 sounds unintuitive to me :\

193

array_key_exists seems more idiomatic here, but isset works.

johnny-bit added a subscriber: johnny-bit.May 3 2015, 5:44 PM

Maybe add to list a typical work closing time? Like ~5pm?

src/view/form/control/AphrontFormDateControlValue.php
190

Lunch is problematic term for Europe and middle east where "Lunch" is anytime between 1(or 12) pm and 4 pm depending on tradition...

Closed by commit rP3ea7359e161d: Support colloquial time names to dramatically improve usability of time control (authored by epriestley, committed by epriestley). · Explain WhyMay 4 2015, 5:09 PM
This revision was automatically updated to reflect the committed changes.
avivey awarded a token.May 4 2015, 5:26 PM

Revision Contents
Changeset List

PathSize
src/
view/
form/
control/
16 lines

Diff 30490

View Options

src/view/form/control/AphrontFormDateControlValue.php

Loading...
Phabricator · Built by Phacility