Page MenuHomePhabricator
Differential D12619

Ability to RSVP to event
ClosedPublic
Actions

Authored by lpriestley on Apr 30 2015, 2:40 AM.
Tags
None
Referenced Files
F14028812: D12619.diff
Fri, Nov 8, 4:09 PM
F14009472: D12619.diff
Wed, Oct 30, 6:26 PM
F13985374: D12619.diff
Sun, Oct 20, 8:07 PM
F13975376: D12619.diff
Fri, Oct 18, 9:52 AM
F13966038: D12619.id30299.diff
Wed, Oct 16, 5:47 AM
F13955637: D12619.id.diff
Mon, Oct 14, 2:18 AM
Unknown Object (File)
Oct 9 2024, 4:40 PM
Unknown Object (File)
Sep 17 2024, 8:09 AM
View All Files
Subscribers
epriestley
Korvin

Details

Reviewers
epriestley
Group Reviewers
Blessed Reviewers
Maniphest Tasks
T7986: Inviting people and RSVP'ing to a Calendar event.
Commits
Restricted Diffusion Commit
rP64c877702664: Ability to RSVP to event
Summary

Closes T7986, Ability to RSVP to event.

Test Plan

Create event, invite users, invited users should see buttons on event detail header to accept/decline. Accepting/declining reflects in the invitee status in the property list.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

lpriestley updated this revision to Diff 30299.Apr 30 2015, 2:40 AM
lpriestley retitled this revision from to Ability to RSVP to event.
lpriestley updated this object.
lpriestley edited the test plan for this revision. (Show Details)
lpriestley added a reviewer: epriestley.
lpriestley added a task: T7986: Inviting people and RSVP'ing to a Calendar event..
Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptApr 30 2015, 2:40 AM
Herald added subscribers: epriestley, Korvin. · View Herald Transcript
epriestley accepted this revision.Apr 30 2015, 2:43 AM
epriestley edited edge metadata.
epriestley added inline comments.
src/applications/calendar/controller/PhabricatorCalendarEventEditController.php
264

For consistency, write this as:

if (condition) {
  continue;
}

(That is, on three separate lines.)

This revision is now accepted and ready to land.Apr 30 2015, 2:43 AM
lpriestley updated this revision to Diff 30300.Apr 30 2015, 2:47 AM
lpriestley edited edge metadata.

What lint missed.

lpriestley marked an inline comment as done.Apr 30 2015, 2:47 AM
Closed by commit rP64c877702664: Ability to RSVP to event (authored by lpriestley, committed by lpriestley). · Explain WhyApr 30 2015, 2:48 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 30301

View Options

src/applications/calendar/application/PhabricatorCalendarApplication.php

Loading...
View Options

src/applications/calendar/controller/PhabricatorCalendarEventEditController.php

Loading...
View Options

src/applications/calendar/controller/PhabricatorCalendarEventJoinController.php

Loading...
View Options

src/applications/calendar/controller/PhabricatorCalendarEventViewController.php

Loading...
Phabricator · Built by Phacility