Expand typeahead document copy
ClosedPublic
Actions

Authored by chad on Apr 27 2015, 4:58 PM.

Details

Reviewers

epriestley

Commits

Restricted Diffusion Commit
rP12dc865a00f9: Expand typeahead document copy

Summary

Seems reasonable? At least, it always matches however a user might think about documents (app or document). Unclear if "Diffusion" for example, are actually needed.

Test Plan

tested searching for "phriction", "wiki", "document", etc.

Diff Detail

Repository

rP Phabricator

Branch

document-tokens

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 5540
Build 5559: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

chad updated this revision to Diff 30193.Apr 27 2015, 4:58 PM

chad retitled this revision from to Expand typeahead document copy.

chad updated this object.

chad edited the test plan for this revision. (Show Details)

chad added a reviewer: epriestley.

Herald added subscribers: epriestley, Korvin. · View Herald TranscriptApr 27 2015, 4:58 PM

These are used in a handful of other places so it's possible some of them will look weird and we'll want to add getShortTypeName() + getFullTypeName() or something, but the other cases all seem like they're probably fine to me from a quick search. This is definitely a lot clearer in global search.

This revision is now accepted and ready to land.Apr 27 2015, 5:04 PM

Closed by commit rP12dc865a00f9: Expand typeahead document copy (authored by chad, committed by chad). · Explain WhyApr 27 2015, 5:06 PM

This revision was automatically updated to reflect the committed changes.