Differential D12572

Always render extra menu nodes, even when logged out
ClosedPublic
Actions

Authored by epriestley on Apr 27 2015, 12:40 PM.

Details

Reviewers

btrahan

Maniphest Tasks

T7915: Logged out search dropdown... unneeded?

Commits

Restricted Diffusion Commit
rPae192e532815: Always render extra menu nodes, even when logged out

Summary

Fixes T7915. This code is a little janky, but make it work for now.

Currently, we render "extra" nodes (dropdowns, etc) only if the user is logged in.

Instead, always render them.

Test Plan

No more "phabricator-help-menu" error in console when logged out.
Search selector now works when logged out.

Diff Detail

Repository

rP Phabricator

Branch

menu1

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 5534
Build 5553: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

epriestley updated this revision to Diff 30184.Apr 27 2015, 12:40 PM

epriestley retitled this revision from to Always render extra menu nodes, even when logged out.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added a reviewer: btrahan.

epriestley added a task: T7915: Logged out search dropdown... unneeded?.

Herald added a subscriber: epriestley. · View Herald TranscriptApr 27 2015, 12:40 PM

btrahan accepted this revision.Apr 27 2015, 2:59 PM

btrahan edited edge metadata.

This revision is now accepted and ready to land.Apr 27 2015, 2:59 PM

Closed by commit rPae192e532815: Always render extra menu nodes, even when logged out (authored by epriestley, committed by epriestley). · Explain WhyApr 27 2015, 3:15 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

help/

application/

PhabricatorHelpApplication.php

22 lines

view/

page/

menu/

PhabricatorMainMenuView.php

14 lines

Diff 30184

View Options

src/applications/help/application/PhabricatorHelpApplication.php