Differential D12556

Use function datasources for a couple more Differential fields
ClosedPublic
Actions

Authored by epriestley on Apr 26 2015, 2:15 PM.

Details

Reviewers

btrahan

Commits

Restricted Diffusion Commit
rPbcb957bc8a57: Use function datasources for a couple more Differential fields

Summary

"Authors" and "Subscribers" convert easily without any extra work.

Test Plan

Used both fields; used functions and normal tokens.

Diff Detail

Repository

rP Phabricator

Branch

morefunc

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 5512
Build 5531: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

epriestley updated this revision to Diff 30140.Apr 26 2015, 2:15 PM

epriestley retitled this revision from to Use function datasources for a couple more Differential fields.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added a reviewer: btrahan.

Herald added a subscriber: epriestley. · View Herald TranscriptApr 26 2015, 2:15 PM

btrahan accepted this revision.Apr 27 2015, 12:33 AM

btrahan edited edge metadata.

This revision is now accepted and ready to land.Apr 27 2015, 12:33 AM

Closed by commit rPbcb957bc8a57: Use function datasources for a couple more Differential fields (authored by epriestley, committed by epriestley). · Explain WhyApr 27 2015, 10:52 AM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

differential/

query/

DifferentialRevisionSearchEngine.php

12 lines

Diff 30140

View Options

src/applications/differential/query/DifferentialRevisionSearchEngine.php

Use function datasources for a couple more Differential fieldsClosedPublicActions