Page MenuHomePhabricator
Differential D12552

Ignore closed branch heads by default in Mercurial
ClosedPublic
Actions

Authored by epriestley on Apr 25 2015, 9:31 PM.
Tags
None
Referenced Files
F14351932: D12552.diff
Thu, Dec 19, 11:42 AM
Unknown Object (File)
Mon, Dec 9, 9:18 PM
Unknown Object (File)
Sun, Dec 8, 8:08 PM
Unknown Object (File)
Tue, Dec 3, 5:06 AM
Unknown Object (File)
Nov 18 2024, 8:47 PM
Unknown Object (File)
Nov 15 2024, 10:17 PM
Unknown Object (File)
Nov 4 2024, 9:06 AM
Unknown Object (File)
Oct 22 2024, 2:50 PM
View All Files
Subscribers
epriestley

Details

Reviewers
btrahan
Maniphest Tasks
T6160: Don't show closed branches of mercurial repository
T7100: Improve handling of ambiguous branch references (tags/branches with the same name, multiple branches heads)
Commits
Restricted Diffusion Commit
rPd3436c256cba: Ignore closed branch heads by default in Mercurial
Summary

Fixes T6160. Ref T7100.

  • When resolving ambiguous branch references, ignore closed heads unless there are no other options.
  • Hide closed heads by default on the main page.
  • Show branch open/closed state in Mercurial.
Test Plan

Browsed a previously-ambiguous Mercurial repository because of multiple branch heads, no longer ambiguous.

Diff Detail

Repository
rP Phabricator
Branch
repo6
Lint
Lint Passed
SeverityLocationCodeMessage
Advicesrc/applications/diffusion/request/DiffusionRequest.php:777XHP16TODO Comment
Unit
Tests Passed
Build Status
Buildable 5508
Build 5527: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

epriestley updated this revision to Diff 30136.Apr 25 2015, 9:31 PM
epriestley retitled this revision from to Ignore closed branch heads by default in Mercurial.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: btrahan.
epriestley added tasks: T7100: Improve handling of ambiguous branch references (tags/branches with the same name, multiple branches heads), T6160: Don't show closed branches of mercurial repository.
Herald added a subscriber: epriestley. · View Herald TranscriptApr 25 2015, 9:31 PM
btrahan accepted this revision.Apr 27 2015, 12:32 AM
btrahan edited edge metadata.
This revision is now accepted and ready to land.Apr 27 2015, 12:32 AM
Closed by commit rPd3436c256cba: Ignore closed branch heads by default in Mercurial (authored by epriestley, committed by epriestley). · Explain WhyApr 27 2015, 10:51 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
applications/
diffusion/
conduit/
11 lines
controller/
1 line
request/
26 lines
view/
20 lines

Diff 30136

View Options

src/applications/diffusion/conduit/DiffusionBranchQueryConduitAPIMethod.php

Loading...
View Options

src/applications/diffusion/controller/DiffusionRepositoryController.php

Loading...
View Options

src/applications/diffusion/request/DiffusionRequest.php

Loading...
View Options

src/applications/diffusion/view/DiffusionBranchTableView.php

Loading...
Phabricator · Built by Phacility