Page MenuHomePhabricator
Differential D12552

Ignore closed branch heads by default in Mercurial
ClosedPublic
Actions

Authored by epriestley on Apr 25 2015, 9:31 PM.
Tags
None
Referenced Files
F18794170: D12552.diff
Thu, Oct 16, 11:07 PM
F18748259: D12552.id30169.diff
Fri, Oct 3, 8:11 PM
F18657625: D12552.diff
Sep 23 2025, 2:40 AM
F18629583: D12552.id.diff
Sep 16 2025, 9:17 AM
F18625837: D12552.diff
Sep 15 2025, 11:42 PM
F18565881: D12552.id.diff
Sep 9 2025, 1:49 PM
F18546874: D12552.diff
Sep 8 2025, 4:50 AM
F18497429: D12552.diff
Sep 4 2025, 6:02 PM
View All Files
Subscribers
epriestley

Details

Reviewers
btrahan
Maniphest Tasks
T6160: Don't show closed branches of mercurial repository
T7100: Improve handling of ambiguous branch references (tags/branches with the same name, multiple branches heads)
Commits
Restricted Diffusion Commit
rPd3436c256cba: Ignore closed branch heads by default in Mercurial
Summary

Fixes T6160. Ref T7100.

  • When resolving ambiguous branch references, ignore closed heads unless there are no other options.
  • Hide closed heads by default on the main page.
  • Show branch open/closed state in Mercurial.
Test Plan

Browsed a previously-ambiguous Mercurial repository because of multiple branch heads, no longer ambiguous.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley updated this revision to Diff 30136.Apr 25 2015, 9:31 PM
epriestley retitled this revision from to Ignore closed branch heads by default in Mercurial.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: btrahan.
epriestley added tasks: T7100: Improve handling of ambiguous branch references (tags/branches with the same name, multiple branches heads), T6160: Don't show closed branches of mercurial repository.
Herald added a subscriber: epriestley. · View Herald TranscriptApr 25 2015, 9:31 PM
btrahan accepted this revision.Apr 27 2015, 12:32 AM
btrahan edited edge metadata.
This revision is now accepted and ready to land.Apr 27 2015, 12:32 AM
Closed by commit rPd3436c256cba: Ignore closed branch heads by default in Mercurial (authored by epriestley, committed by epriestley). · Explain WhyApr 27 2015, 10:51 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
applications/
diffusion/
conduit/
11 lines
controller/
1 line
request/
26 lines
view/
20 lines

Diff 30169

View Options

src/applications/diffusion/conduit/DiffusionBranchQueryConduitAPIMethod.php

Loading...
View Options

src/applications/diffusion/controller/DiffusionRepositoryController.php

Loading...
View Options

src/applications/diffusion/request/DiffusionRequest.php

Loading...
View Options

src/applications/diffusion/view/DiffusionBranchTableView.php

Loading...
Phabricator · Built by Phacility