Page MenuHomePhabricator
Differential D12550

Track closed branches in Mercurial
ClosedPublic
Actions

Authored by epriestley on Apr 25 2015, 9:09 PM.

Details

Reviewers
btrahan
Maniphest Tasks
T6160: Don't show closed branches of mercurial repository
T7100: Improve handling of ambiguous branch references (tags/branches with the same name, multiple branches heads)
Commits
Restricted Diffusion Commit
rP946ea3bffa7d: Track closed branches in Mercurial
Summary

Ref T6160. Ref T7100. Mercurial branch heads can be closed; track this state so we can be smarter about it.

Test Plan

Closed a branch, run repository update, saw it close in the cursor table.

Diff Detail

Repository
rP Phabricator
Branch
repo4
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 5506
Build 5525: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

epriestley updated this revision to Diff 30134.Apr 25 2015, 9:09 PM
epriestley retitled this revision from to Track closed branches in Mercurial.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: btrahan.
epriestley added tasks: T7100: Improve handling of ambiguous branch references (tags/branches with the same name, multiple branches heads), T6160: Don't show closed branches of mercurial repository.
Herald added a subscriber: epriestley. · View Herald TranscriptApr 25 2015, 9:09 PM
btrahan accepted this revision.Apr 26 2015, 11:10 PM
btrahan edited edge metadata.
This revision is now accepted and ready to land.Apr 26 2015, 11:10 PM
Closed by commit rP946ea3bffa7d: Track closed branches in Mercurial (authored by epriestley, committed by epriestley). · Explain WhyApr 27 2015, 10:50 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
resources/
sql/
autopatches/
2 lines
src/
applications/
diffusion/
controller/
2 lines
query/
lowlevel/
56 lines
repository/
engine/
48 lines
storage/
15 lines
2 lines

Diff 30134

View Options

resources/sql/autopatches/20150425.isclosed.sql

Loading...
View Options

src/applications/diffusion/controller/DiffusionRefTableController.php

Loading...
View Options

src/applications/diffusion/query/lowlevel/DiffusionLowLevelMercurialBranchesQuery.php

Loading...
View Options

src/applications/repository/engine/PhabricatorRepositoryRefEngine.php

Loading...
View Options

src/applications/repository/storage/PhabricatorRepository.php

Loading...
View Options

src/applications/repository/storage/PhabricatorRepositoryRefCursor.php

Loading...
Phabricator · Built by Phacility