Page MenuHomePhabricator
Differential D12547

Add a "refs" table to Diffusion
ClosedPublic
Actions

Authored by epriestley on Apr 25 2015, 3:24 PM.
Tags
None
Referenced Files
F14394216: D12547.diff
Sun, Dec 22, 1:48 AM
Unknown Object (File)
Tue, Dec 10, 6:20 PM
Unknown Object (File)
Tue, Dec 3, 11:01 AM
Unknown Object (File)
Thu, Nov 28, 11:14 PM
Unknown Object (File)
Tue, Nov 26, 3:18 AM
Unknown Object (File)
Mon, Nov 25, 7:36 AM
Unknown Object (File)
Nov 21 2024, 3:20 AM
Unknown Object (File)
Nov 16 2024, 10:15 PM
View All Files
Subscribers
epriestley

Details

Reviewers
btrahan
Maniphest Tasks
T7100: Improve handling of ambiguous branch references (tags/branches with the same name, multiple branches heads)
Commits
Restricted Diffusion Commit
rP7f43cde82dd1: Add a "refs" table to Diffusion
Summary

Ref T7100. When a user navigates to a branch like "default" which is ambiguous:

  • don't fatal;
  • choose one alternative to resolve it to (currently more or less at random);
  • sometimes show what we did in the UI.

Also, add a new table to show the alternatives.

This will get refined in followup changes.

Test Plan

Screen_Shot_2015-04-25_at_8.21.11_AM.png (845×1 px, 155 KB)

Screen_Shot_2015-04-25_at_8.21.14_AM.png (845×1 px, 133 KB)

Diff Detail

Repository
rP Phabricator
Branch
repo1
Lint
Lint Passed
SeverityLocationCodeMessage
Advicesrc/applications/diffusion/query/lowlevel/DiffusionLowLevelResolveRefsQuery.php:48XHP16TODO Comment
Advicesrc/applications/diffusion/request/DiffusionRequest.php:759XHP16TODO Comment
Unit
Tests Passed
Build Status
Buildable 5503
Build 5522: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

epriestley updated this revision to Diff 30130.Apr 25 2015, 3:24 PM
epriestley retitled this revision from to Add a "refs" table to Diffusion.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: btrahan.
epriestley added a task: T7100: Improve handling of ambiguous branch references (tags/branches with the same name, multiple branches heads).
Herald added a subscriber: epriestley. · View Herald TranscriptApr 25 2015, 3:24 PM
btrahan accepted this revision.Apr 26 2015, 11:00 PM
btrahan edited edge metadata.
This revision is now accepted and ready to land.Apr 26 2015, 11:00 PM
Closed by commit rP7f43cde82dd1: Add a "refs" table to Diffusion (authored by epriestley, committed by epriestley). · Explain WhyApr 27 2015, 10:50 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
2 lines
applications/
diffusion/
application/
1 line
controller/
131 lines
32 lines
query/
lowlevel/
2 lines
request/
32 lines

Diff 30130

View Options

src/__phutil_library_map__.php

Loading...
View Options

src/applications/diffusion/application/PhabricatorDiffusionApplication.php

Loading...
View Options

src/applications/diffusion/controller/DiffusionRefTableController.php

Loading...
View Options

src/applications/diffusion/controller/DiffusionRepositoryController.php

Loading...
View Options

src/applications/diffusion/query/lowlevel/DiffusionLowLevelResolveRefsQuery.php

Loading...
View Options

src/applications/diffusion/request/DiffusionRequest.php

Loading...
Phabricator · Built by Phacility