Fix call to isGlobalDragAndDropUploadEnabled() from pages with no controller
ClosedPublic
Actions

Authored by epriestley on Apr 24 2015, 10:29 AM.

Details

Reviewers

Maniphest Tasks

T7902: Visiting deleted differential revision causes unrecoverable fatal error

Commits

Restricted Diffusion Commit
rP6f1b39c0b81e: Fix call to isGlobalDragAndDropUploadEnabled() from pages with no controller

Summary

Fixes T7902. Some kinds of error pages, including the 404 page, may not have a controller when they reach this method.

Test Plan

Hit 404 page.

Diff Detail

Repository

rP Phabricator

Branch

quick1

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 5489
Build 5508: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

epriestley updated this revision to Diff 30109.Apr 24 2015, 10:29 AM

epriestley retitled this revision from to Fix call to isGlobalDragAndDropUploadEnabled() from pages with no controller.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added a reviewer: btrahan.

epriestley added a task: T7902: Visiting deleted differential revision causes unrecoverable fatal error.

Herald added a subscriber: epriestley. · View Herald TranscriptApr 24 2015, 10:29 AM

btrahan accepted this revision.Apr 24 2015, 4:03 PM

btrahan edited edge metadata.

This revision is now accepted and ready to land.Apr 24 2015, 4:03 PM

btrahan awarded a token.Apr 24 2015, 4:03 PM

Closed by commit rP6f1b39c0b81e: Fix call to isGlobalDragAndDropUploadEnabled() from pages with no controller (authored by epriestley, committed by epriestley). · Explain WhyApr 24 2015, 4:11 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

view/

page/

PhabricatorStandardPageView.php

8 lines

Diff 30109

View Options

src/view/page/PhabricatorStandardPageView.php

Fix call to isGlobalDragAndDropUploadEnabled() from pages with no controllerClosedPublicActions