Page MenuHomePhabricator
Differential D12516

Tweak uber search dropdown styles
ClosedPublic
Actions

Authored by chad on Apr 23 2015, 12:52 AM.
Tags
None
Referenced Files
F15532877: D12516.diff
Wed, Apr 23, 5:31 PM
F15527899: D12516.id30054.diff
Tue, Apr 22, 7:23 AM
F15526684: D12516.id.diff
Mon, Apr 21, 10:16 PM
F15525835: D12516.id30053.diff
Mon, Apr 21, 5:12 PM
F15522233: D12516.diff
Sun, Apr 20, 6:53 PM
F15457974: D12516.diff
Sun, Mar 30, 8:18 PM
F15385689: D12516.id30054.diff
Mar 14 2025, 11:10 PM
F15341477: D12516.diff
Mar 9 2025, 8:27 PM
View All Files
Subscribers
epriestley
Korvin
Tokens
"Baby Tequila" token, awarded by epriestley.

Details

Reviewers
epriestley
btrahan
Commits
Restricted Diffusion Commit
rP636e5dfda95e: Tweak uber search dropdown styles
Summary

Moved the dropdown outside of the input to give text more space. Also changed the 'current app' icon to the target icon, it feels a little better in use. I will follow up with a fix to T5218.

Test Plan

Tested desktop, mobile, tablet searching.

pasted_file (52×419 px, 14 KB)

Diff Detail

Repository
rP Phabricator
Branch
search-ui-495
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 5454
Build 5472: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

chad updated this revision to Diff 30053.Apr 23 2015, 12:52 AM
chad retitled this revision from to Tweak uber search dropdown styles.
chad updated this object.
chad edited the test plan for this revision. (Show Details)
chad added reviewers: epriestley, btrahan.
Herald added subscribers: epriestley, Korvin. · View Herald TranscriptApr 23 2015, 12:52 AM
chad edited the test plan for this revision. (Show Details)Apr 23 2015, 12:53 AM
epriestley accepted this revision.Apr 23 2015, 12:53 AM
epriestley edited edge metadata.
This revision is now accepted and ready to land.Apr 23 2015, 12:53 AM
chad added inline comments.Apr 23 2015, 12:54 AM
webroot/rsrc/css/application/base/main-menu-view.css
268

suchwow

chad marked an inline comment as done.Apr 23 2015, 12:55 AM
epriestley added inline comments.Apr 23 2015, 12:55 AM
webroot/rsrc/css/application/base/main-menu-view.css
268

I AM GLAD TO SEE THIS IS DONE

chad marked an inline comment as done.Apr 23 2015, 12:56 AM
Closed by commit rP636e5dfda95e: Tweak uber search dropdown styles (authored by chad, committed by chad). · Explain WhyApr 23 2015, 12:56 AM
This revision was automatically updated to reflect the committed changes.
epriestley awarded a token.Apr 23 2015, 12:57 AM

Revision Contents
Changeset List

PathSize
resources/
celerity/
6 lines
src/
view/
page/
menu/
2 lines
webroot/
rsrc/
css/
application/
base/
36 lines

Diff 30053

View Options

resources/celerity/map.php

Loading...
View Options

src/view/page/menu/PhabricatorMainMenuSearchView.php

Loading...
View Options

webroot/rsrc/css/application/base/main-menu-view.css

Loading...
Phabricator · Built by Phacility