Paths

Table of Contentst

Differential D12514

Change XHProf output format
ClosedPublic
Actions

Authored by joshuaspence on Apr 23 2015, 12:25 AM.

Tags

None

Referenced Files

	Unknown Object (File)
	Tue, Dec 31, 11:03 AM

	Unknown Object (File)
	Sat, Dec 28, 5:29 AM

	Unknown Object (File)
	Mon, Dec 16, 9:14 AM

	Unknown Object (File)
	Sat, Dec 7, 5:27 PM

	Unknown Object (File)
	Fri, Dec 6, 6:05 PM

	Unknown Object (File)
	Dec 3 2024, 2:03 PM

	Unknown Object (File)
	Dec 2 2024, 3:18 AM

	Unknown Object (File)
	Dec 2 2024, 3:18 AM

Subscribers

Tokens

"Doubloon" token, awarded by epriestley.

Details

Reviewers

Group Reviewers

Blessed Reviewers

Commits

rPHU20d43107280d: Change XHProf output format

Summary

Currently the output from --xprofile is in compatible with the XHProf application. Specifically, the XHProf application expects JSON encoded data.

Test Plan

Ran a command with --xprofile=profile.json.
Uploaded the profile via arc upload xprofile.json.
Retried the PHID of the uploaded file with echo '{"names": ["Fxxx"]}' | arc call-conduit phid.lookup.
Went to /xhprof/profile/PHID-FILE-xxxxxxxxxxxxxxxxxxxx and saw the profile.

Diff Detail

Repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

joshuaspence updated this revision to Diff 30051.Apr 23 2015, 12:25 AM

joshuaspence retitled this revision from to Change XHProf output format.

joshuaspence updated this object.

joshuaspence edited the test plan for this revision. (Show Details)

joshuaspence added a reviewer: epriestley.

Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptApr 23 2015, 12:25 AM

Herald added subscribers: epriestley, Korvin. · View Herald Transcript

epriestley accepted this revision.Apr 23 2015, 12:51 AM

epriestley edited edge metadata.

This revision is now accepted and ready to land.Apr 23 2015, 12:51 AM

epriestley awarded a token.Apr 23 2015, 12:51 AM

Closed by commit rPHU20d43107280d: Change XHProf output format (authored by joshuaspence, committed by joshuaspence). · Explain WhyApr 23 2015, 9:46 AM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

parser/

argument/

PhutilArgumentParser.php

2 lines

Diff 30065

src/parser/argument/PhutilArgumentParser.php

Loading...