Page MenuHomePhabricator
Differential D12494

Work around mailparse bug (?) with messages that have no terminal newline
ClosedPublic
Actions

Authored by epriestley on Apr 21 2015, 4:31 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Dec 5, 8:31 AM
Unknown Object (File)
Wed, Dec 4, 11:41 PM
Unknown Object (File)
Sun, Dec 1, 9:43 AM
Unknown Object (File)
Wed, Nov 27, 8:45 AM
Unknown Object (File)
Sat, Nov 23, 5:11 AM
Unknown Object (File)
Wed, Nov 20, 3:59 PM
Unknown Object (File)
Wed, Nov 20, 3:59 PM
Unknown Object (File)
Wed, Nov 20, 3:59 PM
View All Files
Subscribers
chad
epriestley

Details

Reviewers
btrahan
chad
Commits
Restricted Diffusion Commit
rP80b23b21f396: Work around mailparse bug (?) with messages that have no terminal newline
Summary

Under some unusual circumstances, mailparse appears to incorrectly discard the last line of some mail messages.

Test Plan
  • Constructed a raw mail with no terminal newline.
  • Piped it into mail_receiver.php.
  • Saw the last line vanish into the aether.
  • Applied patch; repeated; last line survived.

Diff Detail

Repository
rP Phabricator
Branch
mail1
Lint
No Lint Coverage
Unit
No Test Coverage
Build Status
Buildable 5421
Build 5439: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

epriestley updated this revision to Diff 29989.Apr 21 2015, 4:31 PM
epriestley retitled this revision from to Work around mailparse bug (?) with messages that have no terminal newline.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: btrahan.
Herald added a subscriber: epriestley. · View Herald TranscriptApr 21 2015, 4:31 PM
chad accepted this revision.Apr 21 2015, 4:45 PM
chad added a reviewer: chad.
chad added a subscriber: chad.

┻━┻ ︵ヽ(`Д´)ﾉ︵ ┻━┻

This revision is now accepted and ready to land.Apr 21 2015, 4:45 PM
Closed by commit rP80b23b21f396: Work around mailparse bug (?) with messages that have no terminal newline (authored by epriestley, committed by epriestley). · Explain WhyApr 21 2015, 4:49 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
externals/
mimemailparser/
8 lines

Diff 29989

View Options

externals/mimemailparser/MimeMailParser.class.php

Loading...
Phabricator · Built by Phacility