Paths

Table of Contentst

Differential D12494

Work around mailparse bug (?) with messages that have no terminal newline
ClosedPublic
Actions

Authored by epriestley on Apr 21 2015, 4:31 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Thu, Apr 25, 2:27 AM

	Unknown Object (File)
	Sun, Apr 21, 11:25 PM

	Unknown Object (File)
	Fri, Apr 12, 2:19 AM

	Unknown Object (File)
	Tue, Apr 9, 12:04 AM

	Unknown Object (File)
	Tue, Apr 9, 12:04 AM

	Unknown Object (File)
	Sat, Apr 6, 10:21 AM

	Unknown Object (File)
	Tue, Apr 2, 9:49 AM

	Unknown Object (File)
	Sun, Mar 31, 8:37 PM

Subscribers

Details

Reviewers

btrahan
chad

Commits

Restricted Diffusion Commit
rP80b23b21f396: Work around mailparse bug (?) with messages that have no terminal newline

Summary

Under some unusual circumstances, mailparse appears to incorrectly discard the last line of some mail messages.

Test Plan

Constructed a raw mail with no terminal newline.
Piped it into mail_receiver.php.
Saw the last line vanish into the aether.
Applied patch; repeated; last line survived.

Diff Detail

Repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

epriestley updated this revision to Diff 29989.Apr 21 2015, 4:31 PM

epriestley retitled this revision from to Work around mailparse bug (?) with messages that have no terminal newline.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added a reviewer: btrahan.

Herald added a subscriber: epriestley. · View Herald TranscriptApr 21 2015, 4:31 PM

┻━┻ ︵ヽ(`Д´)ﾉ︵ ┻━┻

This revision is now accepted and ready to land.Apr 21 2015, 4:45 PM

Closed by commit rP80b23b21f396: Work around mailparse bug (?) with messages that have no terminal newline (authored by epriestley, committed by epriestley). · Explain WhyApr 21 2015, 4:49 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

externals/

mimemailparser/

MimeMailParser.class.php

8 lines

Diff 29990

externals/mimemailparser/MimeMailParser.class.php

Loading...