Page MenuHomePhabricator

Work around mailparse bug (?) with messages that have no terminal newline
ClosedPublic

Authored by epriestley on Apr 21 2015, 4:31 PM.
Tags
None
Referenced Files
F18023275: D12494.id29989.diff
Sat, Aug 2, 8:53 PM
F17938607: D12494.id29990.diff
Thu, Jul 31, 2:27 AM
F17712655: D12494.id29989.diff
Jul 17 2025, 10:56 AM
F17708245: D12494.diff
Jul 16 2025, 4:30 PM
Unknown Object (File)
May 25 2025, 2:30 AM
Unknown Object (File)
May 23 2025, 3:25 AM
Unknown Object (File)
May 10 2025, 3:50 PM
Unknown Object (File)
May 9 2025, 3:53 PM
Subscribers

Details

Summary

Under some unusual circumstances, mailparse appears to incorrectly discard the last line of some mail messages.

Test Plan
  • Constructed a raw mail with no terminal newline.
  • Piped it into mail_receiver.php.
  • Saw the last line vanish into the aether.
  • Applied patch; repeated; last line survived.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley retitled this revision from to Work around mailparse bug (?) with messages that have no terminal newline.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: btrahan.
chad added a reviewer: chad.
chad added a subscriber: chad.

┻━┻ ︵ヽ(`Д´)ノ︵ ┻━┻

This revision is now accepted and ready to land.Apr 21 2015, 4:45 PM
This revision was automatically updated to reflect the committed changes.