Page MenuHomePhabricator

Distinguish between ported-forward and ported-backward comments
ClosedPublic

Authored by epriestley on Apr 21 2015, 1:19 PM.
Tags
None
Referenced Files
F18842260: D12490.id.diff
Tue, Oct 28, 2:31 PM
F18839166: D12490.diff
Mon, Oct 27, 2:47 PM
F18779466: D12490.id29985.diff
Oct 11 2025, 2:05 PM
F18766710: D12490.id30000.diff
Oct 7 2025, 6:05 PM
F18625434: D12490.id30000.diff
Sep 15 2025, 10:49 PM
F18625098: D12490.diff
Sep 15 2025, 9:58 PM
F18616061: D12490.id29985.diff
Sep 14 2025, 4:06 PM
F18592076: D12490.diff
Sep 12 2025, 11:11 AM
Subscribers

Details

Summary

Ref T7447. This might be overkill, but I want to over-explain things until we have more confidence that this is rarely confusing.

NOTE: I'm playing it a bit fast and loose with setIsGhost() (passing a dictionary) because making API changes requires changing the interface and Diffusion, which is a pain. I'll clean this up at the end once the interface is more final. This is well-contained for now.
Test Plan
  • Viewed "base vs 2" in a diff with 3 diffs, saw some "older comments" and some "newer comments".
  • Hovered the tags for an explanation of comment spookiness.

Screen_Shot_2015-04-21_at_6.18.54_AM.png (413×809 px, 51 KB)

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley retitled this revision from to Distinguish between ported-forward and ported-backward comments.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: btrahan.
btrahan edited edge metadata.
This revision is now accepted and ready to land.Apr 21 2015, 5:33 PM
This revision was automatically updated to reflect the committed changes.