Paths

Table of Contentst

Differential D12490

Distinguish between ported-forward and ported-backward comments
ClosedPublic
Actions

Authored by epriestley on Apr 21 2015, 1:19 PM.

Tags

None

Referenced Files

	F18084340: D12490.id.diff
	Tue, Aug 5, 3:01 PM

	F18073838: D12490.diff
	Mon, Aug 4, 5:29 PM

	F17953917: D12490.id30000.diff
	Fri, Aug 1, 3:35 AM

	F17949104: D12490.id29985.diff
	Thu, Jul 31, 10:51 PM

	F17939661: D12490.id.diff
	Thu, Jul 31, 3:17 AM

	F17938453: D12490.diff
	Thu, Jul 31, 2:13 AM

	F17825949: D12490.id.diff
	Sat, Jul 26, 6:53 AM

	F17825252: D12490.id29985.diff
	Sat, Jul 26, 6:14 AM

Subscribers

Details

Reviewers

Maniphest Tasks

T7447: Bring inline comments forward across revision updates

Commits

Restricted Diffusion Commit
rPfe774e68e255: Distinguish between ported-forward and ported-backward comments

Summary

Ref T7447. This might be overkill, but I want to over-explain things until we have more confidence that this is rarely confusing.

NOTE: I'm playing it a bit fast and loose with setIsGhost() (passing a dictionary) because making API changes requires changing the interface and Diffusion, which is a pain. I'll clean this up at the end once the interface is more final. This is well-contained for now.

Test Plan

Viewed "base vs 2" in a diff with 3 diffs, saw some "older comments" and some "newer comments".
Hovered the tags for an explanation of comment spookiness.

Screen_Shot_2015-04-21_at_6.18.54_AM.png (413×809 px, 51 KB)

Diff Detail

Repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

epriestley updated this revision to Diff 29985.Apr 21 2015, 1:19 PM

epriestley retitled this revision from to Distinguish between ported-forward and ported-backward comments.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added a reviewer: btrahan.

epriestley added a task: T7447: Bring inline comments forward across revision updates.

Herald added a subscriber: epriestley. · View Herald TranscriptApr 21 2015, 1:19 PM

epriestley updated this object.Apr 21 2015, 1:19 PM

btrahan accepted this revision.Apr 21 2015, 5:33 PM

btrahan edited edge metadata.

This revision is now accepted and ready to land.Apr 21 2015, 5:33 PM

Closed by commit rPfe774e68e255: Distinguish between ported-forward and ported-backward comments (authored by epriestley, committed by epriestley). · Explain WhyApr 21 2015, 6:12 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

differential/

controller/

DifferentialChangesetViewController.php

17 lines

infrastructure/

diff/

view/

PHUIDiffInlineCommentDetailView.php

19 lines

Diff 30000

src/applications/differential/controller/DifferentialChangesetViewController.php

Loading...

src/infrastructure/diff/view/PHUIDiffInlineCommentDetailView.php

Loading...