Page MenuHomePhabricator

Distinguish between ported-forward and ported-backward comments
ClosedPublic

Authored by epriestley on Apr 21 2015, 1:19 PM.
Tags
None
Referenced Files
F19945163: D12490.diff
Thu, Apr 16, 3:36 PM
F19945162: D12490.diff
Thu, Apr 16, 3:36 PM
F19828170: D12490.id29985.diff
Mar 9 2026, 4:53 PM
F19152059: D12490.id29985.diff
Dec 11 2025, 12:25 AM
F19069632: D12490.diff
Nov 30 2025, 2:50 PM
F19069237: D12490.diff
Nov 30 2025, 1:21 PM
F19055939: D12490.diff
Nov 28 2025, 6:42 PM
F18982861: D12490.diff
Nov 17 2025, 7:29 AM
Subscribers

Details

Summary

Ref T7447. This might be overkill, but I want to over-explain things until we have more confidence that this is rarely confusing.

NOTE: I'm playing it a bit fast and loose with setIsGhost() (passing a dictionary) because making API changes requires changing the interface and Diffusion, which is a pain. I'll clean this up at the end once the interface is more final. This is well-contained for now.
Test Plan
  • Viewed "base vs 2" in a diff with 3 diffs, saw some "older comments" and some "newer comments".
  • Hovered the tags for an explanation of comment spookiness.

Screen_Shot_2015-04-21_at_6.18.54_AM.png (413×809 px, 51 KB)

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley retitled this revision from to Distinguish between ported-forward and ported-backward comments.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: btrahan.
btrahan edited edge metadata.
This revision is now accepted and ready to land.Apr 21 2015, 5:33 PM
This revision was automatically updated to reflect the committed changes.