Page MenuHomePhabricator

Distinguish between ported-forward and ported-backward comments
ClosedPublic

Authored by epriestley on Apr 21 2015, 1:19 PM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Jun 9, 2:36 AM
Unknown Object (File)
Fri, May 23, 3:25 AM
Unknown Object (File)
May 10 2025, 3:48 PM
Unknown Object (File)
May 10 2025, 1:12 AM
Unknown Object (File)
May 9 2025, 2:11 PM
Unknown Object (File)
May 7 2025, 8:49 AM
Unknown Object (File)
Apr 26 2025, 2:27 PM
Unknown Object (File)
Apr 11 2025, 7:54 PM
Subscribers

Details

Summary

Ref T7447. This might be overkill, but I want to over-explain things until we have more confidence that this is rarely confusing.

NOTE: I'm playing it a bit fast and loose with setIsGhost() (passing a dictionary) because making API changes requires changing the interface and Diffusion, which is a pain. I'll clean this up at the end once the interface is more final. This is well-contained for now.
Test Plan
  • Viewed "base vs 2" in a diff with 3 diffs, saw some "older comments" and some "newer comments".
  • Hovered the tags for an explanation of comment spookiness.

Screen_Shot_2015-04-21_at_6.18.54_AM.png (413×809 px, 51 KB)

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley retitled this revision from to Distinguish between ported-forward and ported-backward comments.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: btrahan.
btrahan edited edge metadata.
This revision is now accepted and ready to land.Apr 21 2015, 5:33 PM
This revision was automatically updated to reflect the committed changes.