Ref T7573. I only got this reproducing like 10% of the time in Firefox but I can't reproduce it anymore after this change.
Details
Details
- Reviewers
btrahan - Maniphest Tasks
- T7573: Ship Quicksand
- Commits
- Restricted Diffusion Commit
rP1602858b2662: Possible fix for JX.History spookiness?
- Added some logging.
- Saw Firefox handing us nonsense state values (?)
- Read the Firefox documentation?
- Maybe state is expected to be an object? This shouldn't matter?
- I don't really know?
Diff Detail
Diff Detail
- Repository
- rP Phabricator
- Branch
- quick1
- Lint
Lint Passed - Unit
No Test Coverage - Build Status
Buildable 5411 Build 5429: [Placeholder Plan] Wait for 30 Seconds
Event Timeline
Comment Actions
This didn't fix it for me unfortunately...
- load /p/btrahan
- observe debug output of path that's getting put into _history member variable: /p/btrahan/
- click /p/btrahan/feed/ link
- Quicksand.js:270 Object {path: "/p/btrahan/feed/", state: 1}
- click back
- Quicksand.js:270 Object {path: "/p/btrahan/", state: 2}
- this should be 0...?
Comment Actions
Yeah, it should be 0. I don't even know where the 2 is coming from. Locally when I repro'd this, we never pushed 2 into the state in the same window that I could see.