Quicksand - provide some plumbing for fancier updates
ClosedPublic
Actions

Authored by btrahan on Apr 17 2015, 7:45 PM.

Details

Reviewers

epriestley

Maniphest Tasks

T7573: Ship Quicksand

Commits

Restricted Diffusion Commit
rP4d5badeec071: Quicksand - provide some plumbing for fancier updates

Summary

Ref D12448. Ref T7573. This changes quicksand up a bit so rather than caching just rendered HTML we also cache the initial response from the server. We also fire off a quicksand-redraw event which will let things like the page objects for notifications update correctly while using Quicksand (see D12448).

Test Plan

loaded up /p/btrahan/ Clicked the UI elements to navigate to various profile views up to maniphest. clicked back until back at /p/btrahan/ and it worked. clicked forward until all the way back to maniphest and it worked. clicked back 2x, then clicked new links, then back and it worked

Diff Detail

Repository

rP Phabricator

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

btrahan updated this revision to Diff 29888.Apr 17 2015, 7:45 PM

btrahan retitled this revision from to Quicksand - provide some plumbing for fancier updates.

btrahan updated this object.

btrahan edited the test plan for this revision. (Show Details)

btrahan added a reviewer: epriestley.

btrahan added a task: T7573: Ship Quicksand.

Herald added subscribers: epriestley, Korvin. · View Herald TranscriptApr 17 2015, 7:45 PM

I think this is over-rendering, see inline...

src/view/page/PhabricatorStandardPageView.php
413	This renders a second copy of the entire page, right? I think we maybe need something like `buildQuicksandConfig()`, and then `renderForQuicksand()` does this: return array( 'content' => $whatever, ) + $this->buildQuicksandConfig(); We'll later just pull the `content` out of the DOM, effectively, so we don't need to ship a second copy down on the initial request.

yeah, sounds right. caught another inline too.

webroot/rsrc/externals/javelin/lib/Quicksand.js
228	this should be moved to below the invoke

changes as discussed plus

wrapper function to make sure JX.History getting consistently called too
rebase

One inline, does it actually work properly?

webroot/rsrc/externals/javelin/lib/Quicksand.js
56	We did not call "JX.History.push()" here before, but now we do. I'd expect this to cause a phantom entry in the history -- you'd have to press "back" twice to get off the page. No?

btrahan added inline comments.Apr 20 2015, 10:41 PM

webroot/rsrc/externals/javelin/lib/Quicksand.js
56	After further testing, yeah that's true. Doh. I'll revert that bit. I'm trying to resolve an issue that doesn't reproduce in Safari but does reproduce in Chrome / Firefox on my Mac. visit a profile with a "clean" browser load and the durable column open click feed click calendar click back (feed) click back (should be profile; is stuck on feed) click back again if possible (should be whatever; is stuck on feed)