Page MenuHomePhabricator

Conpherence - fix policy bug on comments with files in rooms
ClosedPublic

Authored by btrahan on Apr 16 2015, 11:13 PM.
Tags
None
Referenced Files
F19776282: D12443.diff
Sun, Feb 22, 2:28 PM
F19577447: D12443.id.diff
Sun, Feb 1, 10:33 AM
F19378505: D12443.diff
Dec 26 2025, 9:23 PM
F19103572: D12443.diff
Dec 5 2025, 11:22 AM
F18858176: D12443.diff
Nov 1 2025, 9:04 PM
F18853926: D12443.id29859.diff
Oct 31 2025, 8:40 PM
F18760766: D12443.id29860.diff
Oct 6 2025, 10:21 AM
F18710238: D12443.id.diff
Sep 29 2025, 1:40 AM
Subscribers

Details

Summary

Fixes T7840. Add some unit tests. One explicitly covers the case in T7840. Other cases are "base" cases for rooms and threads, plus the version if T7840 for a thread, where a policy exception should be thrown.

Test Plan

arc unit and was able to successfully add a file to a conpherence room i did not have edit permissions on

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable