Page MenuHomePhabricator

Conpherence - fix policy bug on comments with files in rooms
ClosedPublic

Authored by btrahan on Apr 16 2015, 11:13 PM.
Tags
None
Referenced Files
F14037506: D12443.diff
Sun, Nov 10, 4:38 PM
F14035616: D12443.diff
Sun, Nov 10, 6:46 AM
F14021065: D12443.diff
Wed, Nov 6, 5:00 AM
F13993543: D12443.id.diff
Tue, Oct 22, 11:35 PM
F13992244: D12443.id29859.diff
Tue, Oct 22, 3:25 PM
F13988769: D12443.diff
Mon, Oct 21, 3:51 PM
F13962846: D12443.id29860.diff
Oct 15 2024, 12:37 PM
Unknown Object (File)
Sep 30 2024, 11:33 PM
Subscribers

Details

Summary

Fixes T7840. Add some unit tests. One explicitly covers the case in T7840. Other cases are "base" cases for rooms and threads, plus the version if T7840 for a thread, where a policy exception should be thrown.

Test Plan

arc unit and was able to successfully add a file to a conpherence room i did not have edit permissions on

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable