Page MenuHomePhabricator

Conpherence - fix policy bug on comments with files in rooms
ClosedPublic

Authored by btrahan on Apr 16 2015, 11:13 PM.
Tags
None
Referenced Files
F15421092: D12443.id.diff
Fri, Mar 21, 8:58 PM
F15420636: D12443.id29860.diff
Fri, Mar 21, 3:41 PM
F15418793: D12443.id29859.diff
Fri, Mar 21, 1:30 AM
F15399111: D12443.id.diff
Mon, Mar 17, 2:55 AM
F15397796: D12443.diff
Sun, Mar 16, 10:20 PM
Unknown Object (File)
Feb 1 2025, 10:47 PM
Unknown Object (File)
Jan 30 2025, 2:34 PM
Unknown Object (File)
Jan 29 2025, 3:25 AM
Subscribers

Details

Summary

Fixes T7840. Add some unit tests. One explicitly covers the case in T7840. Other cases are "base" cases for rooms and threads, plus the version if T7840 for a thread, where a policy exception should be thrown.

Test Plan

arc unit and was able to successfully add a file to a conpherence room i did not have edit permissions on

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable