Paths

Table of Contentst

Differential D12431

Revamp .device Conpherence layouts
ClosedPublic
Actions

Authored by chad on Apr 15 2015, 11:04 PM.

Tags

None

Referenced Files

	F14853230: D12431.id29850.diff
	Wed, Feb 5, 3:44 AM

	Unknown Object (File)
	Mon, Feb 3, 3:29 AM

	Unknown Object (File)
	Tue, Jan 28, 2:29 AM

	Unknown Object (File)
	Fri, Jan 24, 9:44 AM

	Unknown Object (File)
	Fri, Jan 24, 9:41 AM

	Unknown Object (File)
	Wed, Jan 22, 3:18 AM

	Unknown Object (File)
	Wed, Jan 15, 11:35 PM

	Unknown Object (File)
	Wed, Jan 8, 2:38 AM

Subscribers

Details

Reviewers

epriestley
btrahan

Commits

Restricted Diffusion Commit
rP97c54c3ff586: Revamp .device Conpherence layouts

Summary

Greatly improves the text area and cleans up spacing and color issues.

Test Plan

test Conpherence at desktop, mobile, tablet break points. Test new flexible layouts.

pasted_file (446×324 px, 52 KB)

Diff Detail

Repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

chad updated this revision to Diff 29840.Apr 15 2015, 11:04 PM

chad retitled this revision from to Revamp .device Conpherence layouts.

chad updated this object.

chad edited the test plan for this revision. (Show Details)

chad added reviewers: epriestley, btrahan.

Herald added subscribers: epriestley, Korvin. · View Herald TranscriptApr 15 2015, 11:04 PM

chad edited the test plan for this revision. (Show Details)Apr 15 2015, 11:05 PM

btrahan accepted this revision.Apr 16 2015, 4:16 PM

btrahan edited edge metadata.

btrahan added inline comments.

webroot/rsrc/css/application/conpherence/message-pane.css
273	I think this was misnamed by me in a find / replace and maybe should still be `phabricator-content-source-view`. Maybe not though if line-height and font-size rules aren't desired.
329–332	collapseypoo

This revision is now accepted and ready to land.Apr 16 2015, 4:16 PM

Updates

Closed by commit rP97c54c3ff586: Revamp .device Conpherence layouts (authored by chad, committed by chad). · Explain WhyApr 16 2015, 4:25 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

resources/

celerity/

4 lines

webroot/

rsrc/

css/

application/

conpherence/

message-pane.css

66 lines

Diff 29850

resources/celerity/map.php

Loading...

webroot/rsrc/css/application/conpherence/message-pane.css

Loading...