Paths

Table of Contentst

Differential D12421

Add a linter rule for modifier ordering
ClosedPublic
Actions

Authored by joshuaspence on Apr 15 2015, 12:36 PM.

Details

Reviewers

epriestley

Group Reviewers

Blessed Reviewers

Maniphest Tasks

T7417: Write a linter rule for method modifier ordering

Commits

rARC80691e0a6646: Add a linter rule for modifier ordering

Summary

Fixes T7417. Adds ArcanistXHPASTLinter::LINT_MODIFIER_ORDERING for ensuring that method/property modifiers (public, protected, private, static, abstract and final) are consistently ordered. The modifier ordering that is enforced is consistent with PSR-2.

Test Plan

Added unit tests.

Diff Detail

Repository

rARC Arcanist

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

joshuaspence updated this revision to Diff 29829.Apr 15 2015, 12:36 PM

joshuaspence retitled this revision from to Add a linter rule for modifier ordering.

joshuaspence updated this object.

joshuaspence edited the test plan for this revision. (Show Details)

joshuaspence added a reviewer: epriestley.

Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptApr 15 2015, 12:36 PM

Herald added subscribers: epriestley, Korvin. · View Herald Transcript

The order we use everywhere is:

final/abstract
public/protected/private
static

Is there a strong argument for changing that order?

It's just personal preference.

joshuaspence updated this object.May 13 2015, 9:38 PM

joshuaspence edited edge metadata.

joshuaspence added a task: T7417: Write a linter rule for method modifier ordering.

Rebase, change ordering to be PSR-2 compliant

joshuaspence updated this object.May 19 2015, 10:00 AM

epriestley accepted this revision.May 19 2015, 12:58 PM

epriestley edited edge metadata.

This revision is now accepted and ready to land.May 19 2015, 12:58 PM

Rebase

Closed by commit rARC80691e0a6646: Add a linter rule for modifier ordering (authored by joshuaspence, committed by joshuaspence). · Explain WhyMay 19 2015, 9:27 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

lint/

linter/

ArcanistXHPASTLinter.php

106 lines

__tests__/

xhpast/

array-comma.lint-test

4 lines

modifier-ordering.lint-test

24 lines

unnecessary-final-modifier.lint-test

4 lines

Diff 31156

View Options

src/lint/linter/ArcanistXHPASTLinter.php

View Options

src/lint/linter/tests/xhpast/array-comma.lint-test

View Options

src/lint/linter/tests/xhpast/modifier-ordering.lint-test

View Options

src/lint/linter/tests/xhpast/unnecessary-final-modifier.lint-test

Add a linter rule for modifier orderingClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 31156

src/lint/linter/ArcanistXHPASTLinter.php

src/lint/linter/__tests__/xhpast/array-comma.lint-test

src/lint/linter/__tests__/xhpast/modifier-ordering.lint-test

src/lint/linter/__tests__/xhpast/unnecessary-final-modifier.lint-test

Add a linter rule for modifier ordering
ClosedPublic
Actions

Revision Contents
Changeset List

src/lint/linter/tests/xhpast/array-comma.lint-test

src/lint/linter/tests/xhpast/modifier-ordering.lint-test

src/lint/linter/tests/xhpast/unnecessary-final-modifier.lint-test