Page MenuHomePhabricator
Differential D12413

Clean up some Conpherence beahviors with a mouse
ClosedPublic
Actions

Authored by epriestley on Apr 14 2015, 7:53 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Feb 9, 6:19 PM
Unknown Object (File)
Sat, Feb 8, 3:43 AM
Unknown Object (File)
Sat, Feb 8, 3:42 AM
Unknown Object (File)
Sat, Feb 8, 3:42 AM
Unknown Object (File)
Sat, Feb 8, 3:42 AM
Unknown Object (File)
Sat, Feb 1, 10:06 PM
Unknown Object (File)
Tue, Jan 28, 5:44 AM
Unknown Object (File)
Fri, Jan 24, 5:30 AM
View All Files
Subscribers
epriestley
Tokens
"Piece of Eight" token, awarded by btrahan.

Details

Reviewers
btrahan
chad
Maniphest Tasks
T7825: Conpherence: Sent text floats below breadcrumb-bar
Commits
Restricted Diffusion Commit
rPb40a84c92fa2: Clean up some Conpherence beahviors with a mouse
Summary

Fixes T7825. If JX.Scrollbar activates, we sometimes target the wrong node.

(We don't have this issue in the column because it rebuilds a new JX.Scrollbar every time.)

Test Plan
  • Sent messages, no spooky text.
  • Loaded page, got scroll to bottom.
  • Unplugged all USB devices, restarted browser, repeated.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley updated this revision to Diff 29815.Apr 14 2015, 7:53 PM
epriestley retitled this revision from to Clean up some Conpherence beahviors with a mouse.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: btrahan.
epriestley added a task: T7825: Conpherence: Sent text floats below breadcrumb-bar.
Herald added a subscriber: epriestley. · View Herald TranscriptApr 14 2015, 7:53 PM
chad accepted this revision.Apr 14 2015, 8:04 PM
chad added a reviewer: chad.
This revision is now accepted and ready to land.Apr 14 2015, 8:04 PM
Closed by commit rPb40a84c92fa2: Clean up some Conpherence beahviors with a mouse (authored by epriestley, committed by epriestley). · Explain WhyApr 14 2015, 8:04 PM
This revision was automatically updated to reflect the committed changes.
btrahan awarded a token.Apr 14 2015, 8:22 PM
btrahan edited edge metadata.Apr 14 2015, 9:47 PM

This doesn't seem to work with Chrome / Firefox and a trackpad.

chad added a comment.Apr 14 2015, 9:50 PM

:spin:

epriestley added a comment.Apr 14 2015, 9:55 PM

See D12416.

Revision Contents
Changeset List

PathSize
resources/
celerity/
63 lines
webroot/
rsrc/
externals/
javelin/
lib/
11 lines
js/
application/
conpherence/
22 lines

Diff 29816

View Options

resources/celerity/map.php

Loading...
View Options

webroot/rsrc/externals/javelin/lib/Scrollbar.js

Loading...
View Options

webroot/rsrc/js/application/conpherence/behavior-menu.js

Loading...
Phabricator · Built by Phacility