Differential D12412

Conpherence - refactor CSS a bit
ClosedPublic
Actions

Authored by btrahan on Apr 14 2015, 7:29 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Fri, May 3, 5:44 AM

	Unknown Object (File)
	Thu, Apr 25, 12:57 AM

	Unknown Object (File)
	Mon, Apr 15, 8:30 AM

	Unknown Object (File)
	Fri, Apr 12, 2:41 AM

	Unknown Object (File)
	Thu, Apr 11, 8:42 AM

	Unknown Object (File)
	Apr 1 2024, 8:23 AM

	Unknown Object (File)
	Apr 1 2024, 8:23 AM

	Unknown Object (File)
	Apr 1 2024, 8:23 AM

Subscribers

Details

Reviewers

epriestley
chad

Commits

Restricted Diffusion Commit
rPa91a3cd22f18: Conpherence - refactor CSS a bit

Summary

Follow on to D12410. This kills the general CSS file that once powered application transaction in favor of a specific CSS file for the shared transaction styles for both full view and durable column view. I was able to delete some stuff and identify some shared stuff but there is probably more to go here. Also, rename "phabricator-x" to "conpherence-x" for class names.

Test Plan

viewed full conpherence and durable column conpherence and things looked nice

Diff Detail

Repository

Branch

refactor2

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 5312
Build 5330: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

btrahan updated this revision to Diff 29813.Apr 14 2015, 7:29 PM

btrahan retitled this revision from to Conpherence - refactor CSS a bit.

btrahan updated this object.

btrahan edited the test plan for this revision. (Show Details)

btrahan added a reviewer: epriestley.

Herald added a reviewer: chad. · View Herald TranscriptApr 14 2015, 7:29 PM

Herald added subscribers: epriestley, Korvin. · View Herald Transcript

epriestley accepted this revision.Apr 14 2015, 7:32 PM

epriestley edited edge metadata.

This revision is now accepted and ready to land.Apr 14 2015, 7:32 PM

Closed by commit rPa91a3cd22f18: Conpherence - refactor CSS a bit (authored by btrahan, committed by btrahan). · Explain WhyApr 14 2015, 7:33 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

resources/

celerity/

15 lines

1 line

src/

applications/

conpherence/

view/

ConpherenceTransactionView.php

19 lines

webroot/

rsrc/

css/

aphront/

transaction.css

application/

conpherence/

durable-column.css

49 lines

message-pane.css

66 lines

transaction.css

27 lines

Diff 29813

resources/celerity/map.php

Loading...

resources/celerity/packages.php

Loading...

src/applications/conpherence/view/ConpherenceTransactionView.php

Loading...

webroot/rsrc/css/aphront/transaction.css

Loading...

webroot/rsrc/css/application/conpherence/durable-column.css

Loading...

webroot/rsrc/css/application/conpherence/message-pane.css

Loading...

webroot/rsrc/css/application/conpherence/transaction.css

Loading...