Page MenuHomePhabricator

Conpherence - refactor display classes a bit
ClosedPublic

Authored by btrahan on Apr 14 2015, 6:31 PM.
Tags
None
Referenced Files
F14056276: D12410.diff
Sat, Nov 16, 7:30 PM
F14000639: D12410.id29812.diff
Thu, Oct 24, 11:21 PM
F13994120: D12410.diff
Wed, Oct 23, 3:59 AM
Unknown Object (File)
Sep 4 2024, 10:39 PM
Unknown Object (File)
Sep 4 2024, 11:56 AM
Unknown Object (File)
Sep 1 2024, 11:18 PM
Unknown Object (File)
Aug 29 2024, 11:45 PM
Unknown Object (File)
Aug 25 2024, 9:25 PM
Subscribers

Details

Reviewers
epriestley
Commits
Restricted Diffusion Commit
rP87d360bb1b4a: Conpherence - refactor display classes a bit
Summary

D12409 made me realize this was a bit janky. PhabricatorTransactionView was only being used by Conpherence, so move and rename that class to ConpherenceTransactionView. Also, rename the existing ConpherenceTransactionView to ConpherenceTransactionRenderer, moving the actual view bits into the new ConpherenceTransactionView. Resulting code is a bit cleaner IMO.

Diff 1 of 2 (second diff has to be written. =D). Diff 2 will take care of the CSS and possibly clean things up further.

Test Plan

played around in conpherence full and conpherence column and things looked nice

Diff Detail

Repository
rP Phabricator
Branch
refactor
Lint
Lint Passed
SeverityLocationCodeMessage
Advicesrc/applications/conpherence/view/ConpherenceTransactionView.php:101XHP16TODO Comment
Unit
Tests Passed
Build Status
Buildable 5310
Build 5328: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

btrahan retitled this revision from to Conpherence - refactor display classes a bit.
btrahan updated this object.
btrahan edited the test plan for this revision. (Show Details)
btrahan added a reviewer: epriestley.
epriestley edited edge metadata.
This revision is now accepted and ready to land.Apr 14 2015, 6:39 PM
This revision was automatically updated to reflect the committed changes.