Page MenuHomePhabricator
Differential D12406

Move base drop shadow into CelerityResourceTransformer
ClosedPublic
Actions

Authored by chad on Apr 14 2015, 2:46 AM.
Tags
None
Referenced Files
F17321571: D12406.diff
Thu, Jun 26, 9:42 PM
Unknown Object (File)
May 5 2025, 6:43 PM
Unknown Object (File)
May 1 2025, 10:08 PM
Unknown Object (File)
Apr 26 2025, 5:16 PM
Unknown Object (File)
Apr 25 2025, 1:34 AM
Unknown Object (File)
Apr 17 2025, 10:08 PM
Unknown Object (File)
Apr 16 2025, 8:05 PM
Unknown Object (File)
Mar 31 2025, 7:58 PM
View All Files
Subscribers
epriestley
Korvin

Details

Reviewers
epriestley
Commits
Restricted Diffusion Commit
rPe66d6448b6cd: Move base drop shadow into CelerityResourceTransformer
Summary

Simplifies some common CSS rules.

Test Plan

Test some dialogs and menus.

Diff Detail

Repository
rP Phabricator
Branch
dropshadow
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 5306
Build 5324: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

chad updated this revision to Diff 29802.Apr 14 2015, 2:46 AM
chad retitled this revision from to Move base drop shadow into CelerityResourceTransformer.
chad updated this object.
chad edited the test plan for this revision. (Show Details)
chad added a reviewer: epriestley.
Herald added subscribers: epriestley, Korvin. · View Herald TranscriptApr 14 2015, 2:46 AM
epriestley accepted this revision.Apr 14 2015, 4:41 PM
epriestley edited edge metadata.
This revision is now accepted and ready to land.Apr 14 2015, 4:41 PM
Closed by commit rPe66d6448b6cd: Move base drop shadow into CelerityResourceTransformer (authored by chad, committed by chad). · Explain WhyApr 14 2015, 4:49 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
resources/
celerity/
34 lines
src/
applications/
celerity/
3 lines
webroot/
rsrc/
css/
aphront/
3 lines
application/
base/
4 lines
2 lines
layout/
2 lines
phui/
2 lines
2 lines
5 lines
2 lines

Diff 29802

View Options

resources/celerity/map.php

Loading...
View Options

src/applications/celerity/CelerityResourceTransformer.php

Loading...
View Options

webroot/rsrc/css/aphront/dialog-view.css

Loading...
View Options

webroot/rsrc/css/application/base/main-menu-view.css

Loading...
View Options

webroot/rsrc/css/application/base/notification-menu.css

Loading...
View Options

webroot/rsrc/css/layout/phabricator-hovercard-view.css

Loading...
View Options

webroot/rsrc/css/phui/phui-action-list.css

Loading...
View Options

webroot/rsrc/css/phui/phui-button.css

Loading...
View Options

webroot/rsrc/css/phui/phui-form-view.css

Loading...
View Options

webroot/rsrc/css/phui/phui-pinboard-view.css

Loading...
Phabricator · Built by Phacility