Page MenuHomePhabricator
Differential D12394

Move Conpherence when warning is present
ClosedPublic
Actions

Authored by chad on Apr 13 2015, 5:16 PM.
Tags
None
Referenced Files
F14811159: D12394.id29742.diff
Mon, Jan 27, 2:54 AM
F14811119: D12394.diff
Mon, Jan 27, 2:44 AM
Unknown Object (File)
Fri, Jan 24, 2:32 AM
Unknown Object (File)
Fri, Jan 24, 2:32 AM
Unknown Object (File)
Fri, Jan 24, 2:32 AM
Unknown Object (File)
Fri, Jan 24, 2:32 AM
Unknown Object (File)
Wed, Jan 22, 11:10 PM
Unknown Object (File)
Tue, Jan 21, 4:07 PM
View All Files
Subscribers
epriestley
Korvin

Details

Reviewers
epriestley
btrahan
Maniphest Tasks
T5095: Workboards looks weird when there's an unresolved setup issue
Commits
Restricted Diffusion Commit
rPd56012ce262b: Move Conpherence when warning is present
Summary

Turns out only Conpherence/Durable Column still have issues. Workboards is OK. Simple 2 new CSS classes and punt the issue down the road.

Test Plan

Test Workboards, Conpherence, Durable Column with a setup check issue.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

chad updated this revision to Diff 29742.Apr 13 2015, 5:16 PM
chad retitled this revision from to Move Conpherence when warning is present.
chad updated this object.
chad edited the test plan for this revision. (Show Details)
chad added reviewers: epriestley, btrahan.
Herald added subscribers: epriestley, Korvin. · View Herald TranscriptApr 13 2015, 5:16 PM
epriestley accepted this revision.Apr 13 2015, 5:17 PM
epriestley edited edge metadata.

haha

I do think we should consider shoving this somewhere else sooner or later, but this is easy enough.

This revision is now accepted and ready to land.Apr 13 2015, 5:17 PM
chad added a comment.Apr 13 2015, 5:24 PM

Unintended side effect, the issue is now fixed on scroll. Not sure if awesome or bad.

pasted_file (326×594 px, 103 KB)

Closed by commit rPd56012ce262b: Move Conpherence when warning is present (authored by chad, committed by chad). · Explain WhyApr 13 2015, 5:30 PM
This revision was automatically updated to reflect the committed changes.
chad added a task: T5095: Workboards looks weird when there's an unresolved setup issue.Apr 13 2015, 5:34 PM

Revision Contents
Changeset List

PathSize
resources/
celerity/
8 lines
src/
view/
page/
9 lines
webroot/
rsrc/
css/
application/
conpherence/
4 lines
4 lines

Diff 29743

View Options

resources/celerity/map.php

Loading...
View Options

src/view/page/PhabricatorStandardPageView.php

Loading...
View Options

webroot/rsrc/css/application/conpherence/durable-column.css

Loading...
View Options

webroot/rsrc/css/application/conpherence/menu.css

Loading...
Phabricator · Built by Phacility