Page MenuHomePhabricator

Give Conduit params/return/errors protected visibility
ClosedPublic

Authored by epriestley on Apr 12 2015, 11:02 PM.
Tags
None
Referenced Files
F15468339: D12380.id29723.diff
Thu, Apr 3, 11:27 PM
F15467787: D12380.diff
Thu, Apr 3, 6:03 PM
F15457742: D12380.id29723.largetrue.diff
Sun, Mar 30, 6:23 PM
F15455112: D12380.id.largetrue.diff
Sat, Mar 29, 10:17 PM
F15444994: D12380.id.diff
Thu, Mar 27, 12:11 PM
F15443737: D12380.largetrue.diff
Thu, Mar 27, 5:54 AM
F15438921: D12380.diff
Wed, Mar 26, 4:40 AM
F15367567: D12380.id29771.diff
Tue, Mar 11, 7:34 PM

Details

Summary

Ref T7803. Ref T5873. I want to drive Conduit through more shared infrastructure, but can't currently add parameters automatically.

Put a getX() around the defineX() methods so the parent can provide default behaviors.

Also like 60% of methods don't define any special error types; don't require them to implement this method. I want to move away from this in general.

Test Plan
  • Ran arc unit --everything.
  • Called conduit.query.
  • Browsed Conduit UI.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley retitled this revision from to Give Conduit params/return/errors protected visibility.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: btrahan.
btrahan edited edge metadata.
This revision is now accepted and ready to land.Apr 13 2015, 6:12 PM
This revision was automatically updated to reflect the committed changes.