Page MenuHomePhabricator

Give Conduit params/return/errors protected visibility

Authored by epriestley on Apr 12 2015, 11:02 PM.



Ref T7803. Ref T5873. I want to drive Conduit through more shared infrastructure, but can't currently add parameters automatically.

Put a getX() around the defineX() methods so the parent can provide default behaviors.

Also like 60% of methods don't define any special error types; don't require them to implement this method. I want to move away from this in general.

Test Plan
  • Ran arc unit --everything.
  • Called conduit.query.
  • Browsed Conduit UI.

Diff Detail

rP Phabricator
Automatic diff as part of commit; lint not applicable.
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

epriestley retitled this revision from to Give Conduit params/return/errors protected visibility.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: btrahan.
btrahan accepted this revision.Apr 13 2015, 6:12 PM
btrahan edited edge metadata.
This revision is now accepted and ready to land.Apr 13 2015, 6:12 PM
This revision was automatically updated to reflect the committed changes.