Page MenuHomePhabricator

Give Conduit params/return/errors protected visibility
ClosedPublic

Authored by epriestley on Apr 12 2015, 11:02 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Mar 23, 5:13 PM
Unknown Object (File)
Thu, Feb 29, 10:43 PM
Unknown Object (File)
Feb 21 2024, 4:00 AM
Unknown Object (File)
Feb 5 2024, 8:52 AM
Unknown Object (File)
Feb 3 2024, 3:04 AM
Unknown Object (File)
Feb 3 2024, 3:03 AM
Unknown Object (File)
Feb 3 2024, 3:03 AM
Unknown Object (File)
Feb 3 2024, 3:03 AM

Details

Summary

Ref T7803. Ref T5873. I want to drive Conduit through more shared infrastructure, but can't currently add parameters automatically.

Put a getX() around the defineX() methods so the parent can provide default behaviors.

Also like 60% of methods don't define any special error types; don't require them to implement this method. I want to move away from this in general.

Test Plan
  • Ran arc unit --everything.
  • Called conduit.query.
  • Browsed Conduit UI.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley retitled this revision from to Give Conduit params/return/errors protected visibility.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: btrahan.
btrahan edited edge metadata.
This revision is now accepted and ready to land.Apr 13 2015, 6:12 PM
This revision was automatically updated to reflect the committed changes.