Differential D12380 Authored by epriestley on Apr 12 2015, 11:02 PM.
Details
Summary Ref T7803. Ref T5873. I want to drive Conduit through more shared infrastructure, but can't currently add parameters automatically. Put a getX() around the defineX() methods so the parent can provide default behaviors. Also like 60% of methods don't define any special error types; don't require them to implement this method. I want to move away from this in general. Test Plan
Diff Detail
Event Timelineepriestley updated this object. Herald added subscribers: epriestley, hach-que. · View Herald TranscriptApr 12 2015, 11:02 PM2015-04-12 23:02:34 (UTC+0) btrahan edited edge metadata. This revision is now accepted and ready to land.Apr 13 2015, 6:12 PM2015-04-13 18:12:08 (UTC+0) Closed by commit rP156b156e77b6: Give Conduit params/return/errors protected visibility (authored by epriestley, committed by epriestley). · Explain WhyApr 13 2015, 7:01 PM2015-04-13 19:01:01 (UTC+0) This revision was automatically updated to reflect the committed changes.
Revision Contents
Diff 29771 src/applications/differential/conduit/DifferentialFinishPostponedLintersConduitAPIMethod.phpLoading... src/applications/releeph/conduit/work/ReleephWorkGetBranchCommitMessageConduitAPIMethod.phpLoading... |