Modernize Phriction ordering/paging
ClosedPublic
Actions

Authored by epriestley on Apr 12 2015, 3:04 AM.

Details

Reviewers

Maniphest Tasks

T7809: Advanced search with Order 'Date Updated' is not possible
T7803: Implement a composite query which unifies cursor paging across subqueries

Commits

Restricted Diffusion Commit
rPe0fa0fbdee1b: Modernize Phriction ordering/paging

Summary

Ref T7803. Fixes T7809. Move Phriction away from getReversePaging() / getPagingColumn().

Test Plan

Paged "All Documents", "Updated", and viewed document hierarchy.

Diff Detail

Repository

rP Phabricator

Branch

rpaging10

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 5243
Build 5261: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

epriestley updated this revision to Diff 29682.Apr 12 2015, 3:04 AM

epriestley retitled this revision from to Modernize Phriction ordering/paging.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added a reviewer: btrahan.

epriestley added a task: T7803: Implement a composite query which unifies cursor paging across subqueries.

Herald added a subscriber: epriestley. · View Herald TranscriptApr 12 2015, 3:04 AM

Fix some bugs in the SearchEngine.

epriestley mentioned this in T7809: Advanced search with Order 'Date Updated' is not possible.Apr 13 2015, 2:22 PM

epriestley updated this object.

epriestley added a task: T7809: Advanced search with Order 'Date Updated' is not possible.

ite-klass added a subscriber: ite-klass.Apr 13 2015, 2:41 PM

btrahan accepted this revision.Apr 13 2015, 5:27 PM

btrahan edited edge metadata.

This revision is now accepted and ready to land.Apr 13 2015, 5:27 PM

Closed by commit rPe0fa0fbdee1b: Modernize Phriction ordering/paging (authored by epriestley, committed by epriestley). · Explain WhyApr 13 2015, 7:00 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

phriction/

query/

PhrictionDocumentQuery.php

107 lines

PhrictionSearchEngine.php

4 lines

infrastructure/

query/

order/

PhabricatorQueryOrderVector.php

4 lines

policy/

PhabricatorCursorPagedPolicyAwareQuery.php

9 lines

Diff 29683

View Options

src/applications/phriction/query/PhrictionDocumentQuery.php

View Options

src/applications/phriction/query/PhrictionSearchEngine.php

View Options

src/infrastructure/query/order/PhabricatorQueryOrderVector.php

View Options

src/infrastructure/query/policy/PhabricatorCursorPagedPolicyAwareQuery.php

Modernize Phriction ordering/pagingClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 29683

src/applications/phriction/query/PhrictionDocumentQuery.php

src/applications/phriction/query/PhrictionSearchEngine.php

src/infrastructure/query/order/PhabricatorQueryOrderVector.php

src/infrastructure/query/policy/PhabricatorCursorPagedPolicyAwareQuery.php

Modernize Phriction ordering/paging
ClosedPublic
Actions

Revision Contents
Changeset List